chore(deps): bump joi from 17.13.4 to 18.2.3 - #1691
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 366541c. Configure here.
| "express-joi-validation": "^6.1.0", | ||
| "express-rate-limit": "^8.5.1", | ||
| "joi": "^17.13.3", | ||
| "joi": "^18.2.3", |
There was a problem hiding this comment.
Joi peer mismatch express-joi-validation
Medium Severity
This commit upgrades joi to ^18.2.3 while express-joi-validation ^6.1.0 remains unchanged and declares a peer dependency on joi major version 17. That unsupported pairing can cause npm install/ERESOLVE failures on clean installs (including the Docker npm install path) and leaves all Express request validation on an untested middleware–Joi combination.
Reviewed by Cursor Bugbot for commit 366541c. Configure here.
366541c to
84f453e
Compare
Bumps [joi](https://github.com/hapijs/joi) from 17.13.4 to 18.2.3. - [Commits](hapijs/joi@v17.13.4...v18.2.3) --- updated-dependencies: - dependency-name: joi dependency-version: 18.2.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
84f453e to
5b106a0
Compare


Bumps joi from 17.13.4 to 18.2.3.
Commits
c86ddc018.2.38077125Merge pull request #3125 from hapijs/fix/json-schema-multiple-patterns223217afix: expose multiple string patterns in json schemas85947a8Merge pull request #3124 from hapijs/chore/object-protofe41c4fchore: deny prototype pollution in objects by restoring prototype87d3a6218.2.21c7d34eMerge pull request #3120 from hapijs/fix/json-schema-bugfixes515a8f0test(json-schema): drop runtime validation from json-schema tests6574f75fix(json-schema): register id'd child schemas in $defs770a2cffix(json-schema): skip rule handlers with ref argumentsNote
Medium Risk
Major bump on the library that validates all Express request payloads; subtle rule differences could reject or accept requests that passed on 17.x without any code edits in this PR.
Overview
Bumps
joifrom 17.13.4 to 18.2.3 inpackage.jsonand refreshespackage-lock.jsononly—no application source changes.Joi 18 is a major release: validation internals move from
@sideway/*to@hapi/*(address, formula, pinpoint), adds@hapi/tldsand@standard-schema/spec, and requires Node ≥ 20 (this repo already targets Node ≥ 24). Upstream also includes hardening around object prototype handling and JSON Schema export fixes.Because
express-joi-validationon v1/v2 routes still depends on these Joi schemas, reviewers should treat this as a behavioral dependency upgrade: run the existing API/validation test suites and spot-check endpoints that use string/email/domain rules, where Joi 18 may accept or reject inputs differently than 17.Reviewed by Cursor Bugbot for commit 5b106a0. Bugbot is set up for automated code reviews on this repo. Configure here.