Fix: Add missing models and fix Windows startup - #2
Open
yezhh-pz wants to merge 1 commit into
Open
Conversation
- Added backend/models/schemas.py and task_model.py - Fixed .gitignore to not ignore backend/models/ - Fixed start.bat to activate venv and set PYTHONPATH - Fixed transcribe.py import statement
Owner
|
Thanks for the contribution. We reviewed the issues raised in this PR against the current main branch. Parts of it, such as the current transcription route structure and the startup flow, have already diverged and are now handled differently in main. That said, the underlying issue with the backend/models git ignore rules is valid: some source files under that directory, such as task_model.py, are real code dependencies and should not have been left out of version control. We will address that issue separately in a way that matches the current codebase structure. So while the direction was helpful, this PR is not a clean fit for the current branch. Thanks for pointing it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes critical issues that prevented the project from running on Windows:
Testing
Tested on Windows 11 with Python 3.13.
The application now starts successfully.