fix: declare find_dsh_plugins parameters as standard JSON Schema - #1
Open
245769051-tech wants to merge 1 commit into
Open
fix: declare find_dsh_plugins parameters as standard JSON Schema#1245769051-tech wants to merge 1 commit into
245769051-tech wants to merge 1 commit into
Conversation
….tools.register projects parameters verbatim; the shorthand DSL lacks top-level type object, causing INVALID_REQUEST on every model call)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
\ind_dsh_plugins\ registers through \ctx.tools.register(), which stores the definition verbatim and projects \parameters\ straight to the model API without compiling the shorthand DSL (only the official \defineTool()\ compiles it).
The shorthand object:
\\js
parameters: {
query: { type: 'string', required: true, ... },
limit: { type: 'number', ... },
}
\\
...has **no top-level \ ype: "object"**, so every model call fails with:
\
INVALID_REQUEST: Invalid schema for function 'find_dsh_plugins':
schema must be a JSON Schema of 'type: object', got 'type: null'
\\
The session drops on the first tool call — effectively disconnecting the agent. Reproduced on dsh 0.1.0-rc.6 (DSH Desktop 2.0.0), headless profile.
Fix
Declare a standard JSON Schema root instead:
\\js
parameters: {
type: 'object',
additionalProperties: false,
properties: { query: {...}, limit: {...}, installable_only: {...} },
required: ['query'],
}
\\
Verification
equired: ['query'], execute/render intact.