fix: escape contact/location for idempotency check in cp_gaia_snmp#86
Open
acbk2b wants to merge 1 commit into
Open
fix: escape contact/location for idempotency check in cp_gaia_snmp#86acbk2b wants to merge 1 commit into
acbk2b wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #84 : cp_gaia_snmp contact/location responses contain escaped characters
Why?
The current logic in
cp_gaia_snmpcauses the/setAPI to run every time, but reportschanged: False.This causes unnecessary API calls/writes
Full details described in issue 84
Testing?
I have tested this in my local environment using my GitHub fork as the collection source -- everything is working as intended