AIT-597: Mobile toast clears floating Generate bar + nav - #561
Closed
CharlesHarry7 wants to merge 1 commit into
Closed
AIT-597: Mobile toast clears floating Generate bar + nav#561CharlesHarry7 wants to merge 1 commit into
CharlesHarry7 wants to merge 1 commit into
Conversation
Re-land AIT-447 residual lost off main: Toast parked on nav-only clearance so browse surfaces (library/explore/pricing/…) collided with MobileGenerateBar in the same band above the tab nav. - --toast-clearance stacks bar-h + --mobile-nav-clearance + gap - Toast mobile uses the token; desktop keeps lg:bottom-6 - generate-360 + mobile-proof smokes lock bar-route clearance contract Closes AIT-597. No deploy / no fake UGC / no Stripe live. Co-authored-by: multica-agent <github@multica.ai>
|
Deployment failed for project pikbo-readiness with the following error: Learn More: https://vercel.com/pi-kbo?upgradeToPro=build-rate-limit |
5 tasks
Owner
Author
|
Superseded by #570 (AIT-609). Canonical toast clearance is nav + max(bar-h, sticky-chrome-h) — bar-only formula from AIT-597 should not dual-land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mobile Generate path polish residual: Toast parked on nav-only clearance, so on browse surfaces it collided with
MobileGenerateBarin the same band above the tab nav (AIT-447 was never merged to main).app/globals.css—--toast-clearancestacks--mobile-nav-clearance+--mobile-generate-bar-h+ gapcomponents/Toast.tsx— mobile bottom uses--toast-clearance; desktop keepslg:bottom-6generate-360-cta-smoke+mobile-proof-regression(reject nav-only parking)No color thrash (Toast copper is AIT-583 / #552). No Stripe live, fake UGC, or intentional Vercel deploy.
Closes AIT-597
Test plan
node scripts/generate-360-cta-smoke.mjsnode scripts/mobile-proof-regression.mjsnode scripts/product-proof-smoke.mjs/librarymobile, toast sits above Generate pills + tab + home indicator