Skip to content

fix xccl func register #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chao1Han wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix xccl func register #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions comms/torchcomms/xccl/TorchCommXCCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,11 +550,6 @@ std::shared_ptr<TorchCommBackend> TorchCommXCCL::split(
"XCCL split is not supported now and will be added later");
}

std::shared_ptr<c10::Allocator> TorchCommXCCL::getMemAllocator() {
throw std::runtime_error(
"XCCL getMemAllocator is not supported now and will be added later");
}

XCCLException::XCCLException(
XcclApi& xccl_api,
const std::string& message,
Expand Down
2 changes: 0 additions & 2 deletions comms/torchcomms/xccl/TorchCommXCCL.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ class TorchCommXCCL : public TorchCommBackend,
const std::string& name,
const CommOptions& options = {}) override;

std::shared_ptr<c10::Allocator> getMemAllocator() override;

// Friend access for TorchCommXCCL
friend class TorchWorkXCCL;

Expand Down
4 changes: 0 additions & 4 deletions comms/torchcomms/xccl/TorchWorkXCCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ void TorchWorkXCCL::recordEnd() {
"Failed to record end event");
}

bool TorchWorkXCCL::isCompleted() {
return state_ == WorkStatus::COMPLETED;
}

TorchWorkXCCL::WorkStatus TorchWorkXCCL::checkStatus() {
// If already marked as completed, return COMPLETED
if (state_ == WorkStatus::COMPLETED || state_ == WorkStatus::ERROR ||
Expand Down
1 change: 0 additions & 1 deletion comms/torchcomms/xccl/TorchWorkXCCL.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class TorchWorkXCCL : public TorchWork {
TorchWorkXCCL& operator=(TorchWorkXCCL&&) = delete;

// Override virtual functions from TorchWork
bool isCompleted() override;
void wait() override;

protected:
Expand Down
Loading