fix(novu-bridge): channel-aware dispatch so SMS works

[ChakshuGautam]

Summary

whatsapp was hardcoded in 4 places inside novu-bridge, so even with channel=sms configured in MDMS the dispatch path silently coerced everything into Twilio's WhatsApp pipeline. This is why OTP went out (override path was used directly) but Kafka-driven SMS notifications never worked.

What changed

• NovuBridgeConfiguration / application.properties / compose — default channel flipped from WHATSAPP → SMS. SMS works out-of-the-box with any Twilio sender; WhatsApp requires a pre-approved Programmable WhatsApp number we don't ship.
• TwilioProviderStrategy — whatsapp: prefix on sender number now keyed off ResolvedProvider.channel. For non-WhatsApp channels, also defensively strips any whatsapp: prefix that leaked in from MDMS data.
• DispatchPipelineService — formatWhatsappPhone() renamed to formatRecipientPhone() and made channel-aware. Only prepends whatsapp: on the recipient number when channel=whatsapp. (This was the load-bearing bug — Twilio was rejecting SMS triggers because the To address looked like a WhatsApp address.)
• PreferenceServiceClient — isWhatsAppAllowed() renamed to isChannelAllowed(channel); consent lookup is now consent.get(channel.toUpperCase()) instead of hardcoded "WHATSAPP". A user with SMS=GRANTED but no WHATSAPP entry would otherwise be silently denied.

Test plan

• Build green: mvn clean package -DskipTests
• Container starts healthy on subhashini with NOVU_BRIDGE_CHANNEL=SMS
• Direct Novu trigger with overrides delivers SMS to verified Twilio destination
• Kafka-driven end-to-end: publish complaints.domain.events → bridge → Novu → Twilio SMS delivered (requires MDMS TemplateBinding seed from fix(notif-seed): align seed.sh + schemas with live config-service behavior (corrections for #37) #41)
• OTP flow on Kong /user-otp still delivers (regression check)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ec2beb79-ba53-4f26-a86a-cca78855c5e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/novu-bridge-sms-channel

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[KDwevedi]

Pulled into #52 (the canonical channel-aware novu-bridge dispatch via config.getChannel()). Closing as merged-via-#52.