fix(loc): wire citizen login toggle keys + retitle CS_COMMON_HELPLINE - #13
fix(loc): wire citizen login toggle keys + retitle CS_COMMON_HELPLINE#13KDwevedi wants to merge 1 commit into
Conversation
Citizen UI walk on naipepea (digit-integration-tests#12) found the sidebar HELPLINE label rendered as the literal upper-case word and the mobile/email toggle below the login mobile-number input rendered as raw localization keys. The toggle keys (CS_LOGIN_REGISTER_WITH_EMAIL, CS_USE_MOBILE_INSTEAD, plus the LOGIN_WITH_EMAIL / LOGIN_WITH_MOBILE mobile-viewport variants) were referenced by SelectMobileNumber.js but never seeded; CS_COMMON_HELPLINE shipped with the placeholder value "HELPLINE", which reads as a raw key on the rendered sidebar. Mirrored the same change into both the en_IN and default seed files so fresh tenants don't reintroduce the gap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 22 minutes and 9 seconds.Comment |
Summary
CS_COMMON_HELPLINEshipped with the literal valueHELPLINE(uppercase) — visually indistinguishable from a missing translation. Retitled toHelpline.CS_LOGIN_REGISTER_WITH_EMAIL,CS_USE_MOBILE_INSTEAD, plus theLOGIN_WITH_EMAIL/LOGIN_WITH_MOBILEmobile-viewport variants inpackages/modules/core/src/pages/citizen/Login/SelectMobileNumber.js) was referenced in source but never seeded — added to bothdefaultanden_IN.Mirrored into
default/anden_IN/so fresh tenant bootstraps don't reintroduce the gap.What's already live
The same 5 entries (en_IN) plus 4 sw_KE translations were upserted into the live naipepea localization service today via
/localization/messages/v1/_upsert, so the running citizen UI no longer leaks these keys after a hard refresh / cache bust. This PR captures the change in source-of-truth so re-seeding fromdefault-data-handlermatches.CS_COMMON_HELPLINErainmaker-commondefault,en_INHelpline(wasHELPLINE)CS_LOGIN_REGISTER_WITH_EMAILrainmaker-commondefault,en_INLogin or register with emailCS_USE_MOBILE_INSTEADrainmaker-commondefault,en_INUse mobile number insteadLOGIN_WITH_EMAILrainmaker-commondefault,en_INLogin with emailLOGIN_WITH_MOBILErainmaker-commondefault,en_INLogin with mobileOut of scope (separate fixes)
Two of the four "localization gaps" called out in issue #12 are not actually localization-resolvable — flagging here so they don't get re-filed against this PR:
LAND OWNERSHIP DISPUTE,SURVEYING DELAY, …) —products/pgr/src/pages/citizen/Create/FormExplorer.jspopulates the dropdown straight from the MDMSRAINMAKER-PGR.ServiceDefs.namefield with not()wrap. The MDMS data ships these names in literal upper-snake. Needs either (a) MDMS data fix to title-case thenamefield on the 37 ke.nairobi service defs, or (b) a UI patch to wrap each option's display text int(\SERVICEDEFS.${serviceCode.toUpperCase()}`)(the keys exist inrainmaker-pgr` already).NAIROBI_CENTRALboundary code on the complaint detail Address row —products/pgr/src/pages/citizen/ComplaintDetails.jsrendersaddress?.locality?.name || address?.locality?.codedirectly (not()). The stored complaint haslocality.name=null, so the code-fallback shows. Needs either a UI patch to wrap the fallback int()and seedNAIROBI_CENTRAL(and the other 16 sub-county codes), or a fix at the create-complaint payload layer to populatelocality.namefrom the boundary-service lookup.Test plan
curl /localization/messages/v1/_searchfor each of the 5 codes returns the new value in en_IN and the 4 toggle-link codes return Swahili in sw_KE.default-data-handlerseed of a new tenant picks up the corrected values automatically.🤖 Generated with Claude Code