Fix Phase 3 + Phase 4 create payload shapes to match backend schemas

[KDwevedi]

Summary

Walked the configurator onboarding flow end-to-end against a live naipepea backend on 2026-04-21. Phase 1 (Tenant) and Phase 2 (Boundaries) worked. Phase 3 (Departments / Designations / Complaint Types) and Phase 4 (Employees) were broken — the FE was sending payloads that the backend rejected.

All four bugs are FE-only. The backend schemas are the source of truth; the FE just needs to match them.

Fixes (4 commits, one per bug)

Commit	Issue	What
a7782a17	#1	RAINMAKER_PGR.ServiceDefs → RAINMAKER-PGR.ServiceDefs (1-line config)
11004e05	#2	Designation payload: add required description, change department to string[]
36213af3	#3	ServiceDefs payload: rename serviceName→name, add required keywords
dd309bda	#4	Employee payload: populate user.dob (HRMS Java @NotNull)

Each commit is self-contained and reviewable in under 5 minutes.

Reproduction (before this PR)

# Phase 3 Designation:
POST /mdms-v2/v2/_create/common-masters.Designation
→ {"Errors":[
    {"code":"INVALID_REQUEST_TYPE1","message":"expected type: JSONArray, found: String"},
    {"code":"INVALID_REQUEST_REQUIRED2","message":"required key [description] not found"}
  ]}

# Phase 3 ComplaintType (after fixing the schema-code typo):
POST /mdms-v2/v2/_create/RAINMAKER-PGR.ServiceDefs
→ {"Errors":[
    {"code":"INVALID_REQUEST_REQUIRED2","message":"required key [keywords] not found"},
    {"code":"INVALID_REQUEST_REQUIRED1","message":"required key [name] not found"},
    {"code":"INVALID_REQUEST_ADDITIONALPROPERTIES3","message":"extraneous key [serviceName] is not permitted"}
  ]}

# Phase 4 Employee:
POST /egov-hrms/employees/_create
→ {"Errors":[{"code":"NotNull.employeeRequest.employees[0].user.dob","message":"must not be null"}]}

Verification

Will re-walk the full onboarding flow with a disposable tenant (ke.bananaland-<timestamp>) against naipepea after merge to confirm all four phases complete end-to-end. Dummy data cleanup via the same SQL pattern used in the pre-PR verification (available on request).

Test plan

• Phase 1 (Tenant) — unaffected, re-verify passes
• Phase 2 (Boundaries) — unaffected, re-verify passes
• Phase 3 upload with an Excel sheet containing Department + Designation + ComplaintType rows → creates succeed
• Phase 3 Designation row with no description column → falls back to name (backwards compat)
• Phase 3 ComplaintType row with no keywords column → auto-generated from name.toLowerCase().split(/\s+/).join(',')
• Phase 3 ComplaintType row with legacy serviceName column header → parser falls back, still works
• Phase 4 upload with Employee rows (no DOB column) → uses 1990-01-01 default, HRMS accepts
• Phase 4 with explicit dob column → parsed and threaded through

Follow-ups (out of scope here)

• Schema-driven payload construction (proper fix): drive mdmsService.create* off the live MDMS schema definition via /mdms-v2/schema/v1/_search instead of hand-written field lists. Design in Nai Pepea/issues/FIX-PLAN.md (Layer B). Would have caught all three of Add local-setup: Docker Compose dev environment #1-feat: add Keycloak auth adapter for Google SSO #3 at FE-build time.
• Surface DOB in the UI as a proper employee form field or a required Excel column, instead of defaulting to 1990.
• generateUsername() in hrmsService is effectively dead code — HRMS overrides userName with employee.code on create. Worth a docstring note or removal.

Closes #1, closes #2, closes #3, closes #4.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee8934e3-915a-4b63-bcdb-a8a1f55d95ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[KDwevedi]

Adding a 5th fix: createTenant also omits the required tenantId field inside the data payload. Surfaced during a self-walk of the configurator UI (my initial walk used hand-built curl with tenantId already in it, so Phase 1 looked fine).

Backend response pre-fix:

{"Errors":[{"code":"INVALID_REQUEST_REQUIRED1","message":"required key [tenantId] not found"}]}

Commit f6fbe39a adds tenantId: stateTenantId to the tenantData object. Closes #5.

Rebuilt + redeployed on naipepea — new bundle index-DNbpYGcp.js. Re-verified Phase 1 via the UI (with the test assets in Nai Pepea/onboarding-test-assets/) works now.

[KDwevedi]

6th commit added: f3e2a40d — searchBoundaries was calling /boundary-service/boundary/_search which doesn't return the hierarchy tree, so Phase 4 reported 0 boundaries even when they existed. Swapped to /boundary-service/boundary-relationships/_search with query-string params. Closes #6.

Verified on naipepea: post-fix bundle index-BqA9OCiL.js now loads all 4 test boundaries into Phase 4's jurisdiction picker.

[KDwevedi]

Superseded by work targeting the extracted ChakshuGautam/digit-configurator repo. The configurator moved out of the CCRS monorepo today — porting these fixes there instead. See Nai Pepea/issues/FIX-PLAN.md for the underlying 9 issues (#1-#6 filed on theflywheel fork; #7-#9 uncovered during live walk on 2026-04-21). Branch theflywheel/fix/onboarding-payload-shapes preserved for the diff.