fix: HRMS, PII masking, and localization bugs (Bomet deployment) - #10
Open
ChakshuGautam wants to merge 1 commit into
Open
fix: HRMS, PII masking, and localization bugs (Bomet deployment)#10ChakshuGautam wants to merge 1 commit into
ChakshuGautam wants to merge 1 commit into
Conversation
…oyment) Five bugs found during Bomet County Kenya deployment: 1. Kong: Add /egov-mdms-service v1 compat route (HRMS UI calls old v1 path) 2. TenantBoundary: Root boundary.code must match tenant code for HRMS jurisdiction validation (was using boundary level name) 3. SecurityPolicy: Add PGR roles (GRO, PGR_LME, EMPLOYEE, etc.) to encryption decryption policy — employee names showed masked as "B*XXXXXXXXX" on Assign Complaint 4. Boundary localizations: Seed EGOV_LOCATION_BOUNDARYTYPE_* and ADMIN_* messages so UI shows human-readable labels 5. Boundary code localizations: Seed code->name messages in ci-dataloader-xlsx.py so ward/subcounty names display correctly Also includes: - Fix ServiceDefs localization code generation (SERVICEDEFS_ prefix, not SERVICEDFS.) - Update boundary-service image to v2.9.2-dual-mode - Add Kong UNTRUSTED_LUA_SANDBOX_REQUIRES for auth enrichment plugin - Simplify crs_loader.py bootstrap and module enablement Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/egov-mdms-service/*— Kong had no route for this path, all v1 MDMS calls returned 404ke.bomet), not boundary name — HRMS jurisdiction validation requires this (ERR_HRMS_INVALID_JURISDICTION_HEIRARCHY)B*XXXXXXXXXon Assign ComplaintADMIN_SUBCOUNTY,EGOV_LOCATION_BOUNDARYTYPE_COUNTY— localization messages must be seeded for each boundary hierarchy levelBOMET_CHEPALUNGU) instead of human names — localization must be seeded for each boundary codeSERVICEDFS.(typo) instead ofSERVICEDEFS_, and module wasrainmaker-pgrinstead ofrainmaker-commonType of Change
Files Changed
local-setup/kong/kong.yml— Add MDMS v1 compat routelocal-setup/jupyter/dataloader/crs_loader.py— Fix TenantBoundary root boundary.code + add boundary localization seeding + simplify bootstraplocal-setup/db/mdms-security-seed.sql— Add PGR roles to encryption SecurityPolicylocal-setup/scripts/ci-dataloader-xlsx.py— Add boundary code localization seeding (step 9)local-setup/jupyter/dataloader/unified_loader.py— Fix ServiceDefs localization code generationlocal-setup/docker-compose.registry.yml— Update boundary-service image, add Kong Lua sandbox configPlatform Impact
Test plan
🤖 Generated with Claude Code