feat: allow proposer reorgs at epoch boundaries - #9769
Conversation
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ae54fba14
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return {prelimProposerHead, prelimNotReorgedReason: NotReorgedReason.AtEpochBoundary}; | ||
| } | ||
|
|
||
| // No reorg if headBlock and parentBlock are not ffg competitive |
There was a problem hiding this comment.
Accept parent bids when enabling boundary reorgs
For a Gloas proposer reorg at the first slot of an epoch, this now selects the weak head's parent, but isBidCompatibleWithHead() in packages/beacon-node/src/chain/validation/executionPayloadBid.ts:63-66 still rejects every bid building on that parent when bidSlot is an epoch boundary. Because both gossip and API bid validation use that predicate, no matching bid reaches the pool queried during block production, forcing the proposer to discard valid builder bids precisely when this new reorg path is taken.
Useful? React with 馃憤聽/ 馃憥.
There was a problem hiding this comment.
yeah this is valid, and I was aware of it before, not sure we can solve this easily
Performance Report鉁旓笍 no performance regression detected Full benchmark results
|
see ethereum/consensus-specs#5492