-
-
Notifications
You must be signed in to change notification settings - Fork 475
fix(epbs): checkpoint restart stability + finalized state API parity #9005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
lodekeeper
wants to merge
4
commits into
ChainSafe:epbs-devnet-0
from
lodekeeper:fix/epbs-state-restart
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3210d92
fix(epbs): stabilize checkpoint restart + finalized state semantics
lodekeeper 1572659
chore(epbs): simplify Gloas state casts in forkchoice init
lodekeeper 8cce2b4
fix(epbs): harden head-state and checkpoint state fallback paths
lodekeeper 87a6cd5
test(epbs): add regression coverage for restart fallback paths
lodekeeper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
executionPayloadNumberis hardcoded to0for post-Gloas anchor initialization here (and repeated in the unfinalized initializer), which drops the execution height available from the loaded state.ForkChoice.onBlock()computes childexecutionPayloadNumberfromparentBlock.executionPayloadNumber, andgetPayloadAttributesForSSE()forwards that value to payload-attributes events, so a restarted node can emit near-zero parent block numbers and propagate incorrect numbering until envelopes are replayed. This is a correctness regression for APIs/consumers that depend onparent_block_numbercontinuity.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — I took a close look here. For post-Gloas checkpoint init we currently do not have an execution block number in state (EIP-7732 removed
latestExecutionPayloadHeader, andlatestExecutionPayloadBidhas hashes/value but no block number), so we cannot recover a reliable parent block number at this initialization point.\n\nI kept0as a sentinel for now to avoid fabricating potentially wrong heights, and to keep this PR focused on the restart + finalized-state correctness fixes. I agree this is worth improving separately (e.g., deriving from persisted envelope/index when available). I can open a follow-up task for that if you want.