-
-
Notifications
You must be signed in to change notification settings - Fork 475
feat: gloas range sync (rebased onto epbs-devnet-0) #9000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
lodekeeper
wants to merge
14
commits into
ChainSafe:epbs-devnet-0
from
lodekeeper:fix/merge-syncing-to-devnet-0
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d3f95e5
feat: implement execution_payload_envelopes_by_range p2p
twoeths 7756434
feat: update downloadByRange pipeline
twoeths 6555ed3
feat: implement gloas processChainSegment
twoeths 866feda
fix: dedup processChainSegments
twoeths b4547de
fix: verify envelope signature separately
twoeths 47c5f67
chore: use isGloasDataColumnSidecar() in downloadByRange
twoeths 78ae5a1
fix: getBlobKzgCommitmentsCountFromSignedBeaconBlockSerialized
twoeths 37b91d9
feat: archive EnvelopesFromHotToColdD
twoeths 9fcaceb
feat: importBlock to import envelope state as well
twoeths b393ce1
fix: lint
twoeths 23819a2
fix: add PayloadStatus to getAllAncestorAndNonAncestorBlocks()
twoeths fc31669
fix: getAllAncestorBlocks() to support ProtoBlock
twoeths 3ff4fa7
fix: gloas range sync e2e
twoeths bade350
merge: resolve conflicts from epbs-devnet-0 into te/epbs-devnet-0_syn…
lodekeeper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic to populate
finalizedCanonicalBlockRootscan be simplified. The linefinalizedCanonicalBlockRoots.push(rootAndSlot)is present in both theifandelsebranches of theisPostGloasBlockcheck. This can be moved out of the conditional to avoid repetition and make the code slightly cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid style nit — the
push()could be hoisted out of the conditional. Not changing it in a merge-resolution PR to keep the diff minimal, but noted for a future cleanup pass.