feat: wire sidebar, toast notifications, and fix module completion state#7
Merged
Merged
Conversation
✅ Deploy Preview for chainlearn ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add ToastContextProvider for shared cross-component toast state - Wrap layout with ToastProvider, remove per-page ToastContainer instances - Fix ModuleList always showing modules as incomplete (pass enrollment.completedModules) - Convert all pages from local useToast to context-based useToastContext
0ab70d2 to
138a1bd
Compare
Contributor
Author
Review SummaryRetargeted to What's Good
Note
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToastProviderfor shared cross-component toast stateModuleListalways showing modules as incomplete — now passesenrollment.completedModulesinstead of[]Closes #9, #10, #11
Test plan