Skip to content

OCA chat completions and responses bug fix - #12

Open
ChaiEranki wants to merge 1 commit into
main-base-responsesfrom
oca-chat-responses-switch
Open

OCA chat completions and responses bug fix#12
ChaiEranki wants to merge 1 commit into
main-base-responsesfrom
oca-chat-responses-switch

Conversation

@ChaiEranki

@ChaiEranki ChaiEranki commented Jan 10, 2026

Copy link
Copy Markdown
Owner

Related Issue

Issue: #XXXX

Description

Sometimes chat completions with GPT 5 model family can return tool calls with the id starting with "call_" when Responses API expects "fc_". This PR fixes this by just checking if the tool call has an id of "call_" and changing it to "fc_" before sending the input to our Responses API endpoint.

Test Procedure

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor Changes
  • 💅 Cosmetic Changes
  • 📚 Documentation update
  • 🏃 Workflow Changes

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • Tests are passing (npm test) and code is formatted and linted (npm run format && npm run lint)
  • I have created a changeset using npm run changeset (required for user-facing changes)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

@ChaiEranki
ChaiEranki changed the base branch from main-base-responses to main-base January 10, 2026 05:08
@ChaiEranki
ChaiEranki changed the base branch from main-base to main-base-responses January 10, 2026 05:08
@ChaiEranki
ChaiEranki changed the base branch from main-base-responses to ceranki/rag-changes-fresh January 10, 2026 05:09
@ChaiEranki
ChaiEranki changed the base branch from ceranki/rag-changes-fresh to main-base-responses January 10, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant