Fix FunWithFlags boolean gate migration#13
Merged
Conversation
Prevents and fixes duplicate boolean gate rows that occur when migrating from FunWithFlags to Bandera using an existing Ecto table. Root cause: FunWithFlags stored boolean gates with a legacy target value; Bandera uses "_bandera_none". The upsert conflict key is (flag_name, gate_type, target), so the two sentinels don't conflict — a second row is inserted rather than updating the first. The symptom is a dashboard toggle that shows "on" while the summary shows "off", and clicking the toggle appears to do nothing. Changes: - Add boolean-specific put/2 to the Ecto store that deletes any existing boolean row before inserting, preventing duplicates going forward - Add Bandera.Ecto.Migrations.fix_fun_with_flags_boolean_gates/0, a migration helper for one-time cleanup of duplicates already in the DB - Add mix bandera.gen.fix_fun_with_flags_migration to scaffold the migration file in one command - Add a warning block to the migration guide Step 5 (Option A)
Ch4s3
force-pushed
the
fix/fun-with-flags-boolean-gate-migration
branch
from
June 1, 2026 20:28
3e2bf56 to
3b4b54b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
put/2to the Ecto store that deletes any existing boolean row (regardless of target sentinel) before inserting the new one. FunWithFlags used a different target value than Bandera's"_bandera_none"sentinel, so the upsert conflict key(flag_name, gate_type, target)didn't match — a second row was inserted instead of updating the first.Bandera.Ecto.Migrations.fix_fun_with_flags_boolean_gates/0, a migration helper for the one-time cleanup of duplicate rows already in the database.mix bandera.gen.fix_fun_with_flags_migrationto scaffold the migration file in one command.Symptom
After migrating from FunWithFlags with an existing table, a flag's dashboard toggle showed "on" while the summary showed "off · N actors", and clicking the toggle appeared to do nothing.
Test Plan
mix test— 406 passing, 13 excludedmix bandera.gen.fix_fun_with_flags_migration --path /tmp/smoke && cat /tmp/smoke/*.exs— generates a correctly timestamped migration filemix ecto.migratewith the generated migration; confirm legacytarget = "boolean"rows becometarget = "_bandera_none"and duplicates are removed