feat(dashboard): summaries + editor controls for the 5 new gate types#10
Merged
Ch4s3 merged 15 commits intoMay 23, 2026
Merged
Conversation
Switch coverage from Mix's built-in tool to ExCoveralls so coverage can be uploaded to coveralls.io and surfaced as a README badge. - mix.exs: add :excoveralls (test-only), set test_coverage tool to ExCoveralls, add cli/0 preferred_envs so `mix coveralls` runs in :test. - coveralls.json: port the old ignore_modules to skip_files (file paths) and the 85% threshold to coverage_options.minimum_coverage. ExCoveralls filters by file path, not module. - CI: replace `mix test --cover` with `mix coveralls.github` (uploads) plus `mix coveralls` (enforces the 85% gate in-repo, unchanged behavior). - README: add the Coveralls badge.
ci: add test coverage badge via ExCoveralls
docs: fix coverage badge URL case
The Ecto persistence adapter is backend-agnostic (standard column types, runtime-bound table, no DB-specific SQL) and SQLite is the backend the test suite runs against, but the README only mentioned Postgres. Note :ecto_sqlite3 in the deps comment and add a short backend-agnostic note to the Ecto section.
docs: document SQLite as a supported Ecto backend
Tier 1 feature gap improvements (all 9 features)
…gate-types # Conflicts: # test/bandera/prerequisites_test.exs # test/bandera/rules_test.exs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #6. PR #6 added five new gate types (
:variant,:rule,:segment,:prerequisite,:schedule) with construction, storage, and evaluation, but never touched the LiveView dashboard — flags using them rendered a blank summary and had no editor controls. This PR closes that gap in three layers:lib/bandera/dashboard/components.ex):summary_parts/1now renders all five new types — variant weights (variants blue 50%, green 50%), rule constraint count (rule (2 constraints)), segment/prerequisite counts (mirroring actors/groups), and schedule windows (scheduled <from> → <until>, with open-ended handling).lib/bandera/dashboard/flags_live.ex): five new fieldsets with create/remove for variants (weight map), rules (full attribute + 10-operator + comma-split-values constraint builder), segments (by name), prerequisites (parent flag<select>+ on/off polarity), and schedules (ISO-8601 from/until). Uncontrolled-form pattern, consistent flash/validation, and the boolean toggle is unchanged.lib/bandera.ex): PR Tier 1 feature gap improvements (all 9 features) #6 added create options but no matching clear; this addsclear(flag, variant: true | rule: true | for_segment: name | requires: parent | schedule: true), keyed on the correctGate.id/1slot. @pr Tier 1 feature gap improvements (all 9 features) #6 author — theseclear/2clauses complete your API surface; flagging for your review since they logically belong with the gate types.Test plan
mix test— 371 passed (81 doctests, 8 properties, 282 tests), 13 excluded (redis)mix format --check-formattedcleanmix compile --warnings-as-errorscleancomponents_test.exs), per-type add/remove + validation in the LiveView (flags_live_test.exs), and per-typeclear/2cases in the matching feature test files.Notes / follow-ups
clear_percentagehandler doesn't clear:flash_erroron success — now the lone outlier among clear/remove handlers (this PR alignedremove_actor/remove_group). Trivial one-line follow-up, left out of scope.🤖 Generated with Claude Code