feat: sync skills to CesiumJS 1.144 with optimized wording - #27
Open
jdehorty wants to merge 1 commit into
Open
Conversation
Skills-only consolidation of three streams, scoped to skills/**: 1. feat/eval-and-optimization skill improvements — the optimization-loop wording that the tracked all-pass baselines were rendered from (recipes, framing guidance, render-readiness and provider patterns). 2. justin/czmjs-1144-sync-eval (7d95669) — the CesiumJS 1.144 release sync: - Camera: composable Controller framework (ControllerHost, 5 ScreenSpace controllers, MouseButton, ScreenSpaceInputBindings, Viewer.addController) with canonical asset-inspection setup - Interaction: Scene.snap + SceneSnapResult experimental edge-snap picking - 3D Tiles: UrlTemplate3DTilesDataProvider base class; automatic terrain draping of clamped vector tile polylines/polygons - Imagery: feature-info picking for layers draped on 3D Tiles - Models: BENTLEY_materials_planar_fill (wireframeFill no-op), KHR_mesh_primitive_restart, edge-visibility typed-array memory note - Materials: Texture.defaultColor placeholder note 3. API-verification refinements (validated against the published cesium@1.144 package: Cesium.d.ts + runtime exports, CHANGES.md, engine sources): - KHR_mesh_primitive_restart is not ratified (Khronos PR still open) - Per-controller tuning knobs documented as shipped (panSpeed/inertia* on pan controllers, dampingEnabled on tilt-orbit/zoom, angleThreshold on hybrid); input remapping stays on ScreenSpaceCameraController *EventTypes - Entity hover material-swap variant + graphics-type fidelity note - All 14 skill version baselines bumped to 1.144 The camera skill three-way merges the eval-branch content with main's #24 (flyToBoundingSphere target framing); both guidance sets are preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jdehorty
added a commit
that referenced
this pull request
Aug 27, 2026
…js-v1.144-skills) Make skills/ byte-identical to PR #27 (49e0612) so the operational eval branch renders baselines from the same wording that ships to main: - camera: three-way merge of main's #24 (flyToBoundingSphere target framing, quick-reference rows) with the 1.144 Controller framework - bump the version-baseline line to 1.144 in the 8 skills the release sync did not otherwise touch (core-utilities, custom-shader SKILL + REFERENCE, entities, primitives, spatial-math, terrain-environment, time-properties) Validated as-is: deterministic gate PASS; 46/47 live scenarios pass (camera eval-006 settle-gate failure is host-load-caused, control-proven with a byte-identical previously-passing source). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Syncs the skills package to CesiumJS 1.144 (released 2026-08-01; no breaking changes, no deprecations), scoped to
skills/**only — 17 files, +1623/−168. No eval infra, config, docs, or README changes (follow-up planned for those).Consolidates three streams:
feat/eval-and-optimizationskill improvements — the optimization-loop wording the tracked all-pass baselines were rendered from: hover/selection recipes, camera framing guidance, tileset render-readiness patterns, provider hygiene, time/property recipes, and expanded quick-reference tables across all 14 domain skills.CesiumJS 1.144 release sync (from
justin/czmjs-1144-sync-eval@ 7d95669):Controllerframework:ControllerHost,ScreenSpaceMapCameraController,ScreenSpaceElevatorCameraController,HybridScreenSpacePanCameraController,ScreenSpaceTiltOrbitCameraController,ScreenSpaceZoomCameraController,MouseButton,ScreenSpaceInputBindings,Viewer.addControllercesiumjs-cameraScene.snap+SceneSnapResultexperimental edge-snap pickingcesiumjs-interactionUrlTemplate3DTilesDataProviderbase class; automatic terrain draping of clamped vector tile polylines/polygonscesiumjs-3d-tilescesiumjs-imageryBENTLEY_materials_planar_fillsupport,KHR_mesh_primitive_restart, edge-visibility typed-array loading (~19x less JS heap)cesiumjs-models-particlesTexture.defaultColorplaceholder color (runtime-public, untyped)cesiumjs-materials-shadersAPI-verification refinements — every 1.144 claim was checked against the published
cesium@1.144npm package (Cesium.d.ts+ runtime import), the officialCHANGES.md, and engine sources:Cesium.d.ts; 11 are runtime-real.GRID_TARGET_SEGMENTS_PER_CELLis a declaration-only leak (undefinedat runtime) — noted so agents never import it.KHR_mesh_primitive_restartis not ratified (Khronos glTF PR #2569 still open) — described as the multi-vendor KHR successor still in review.ScreenSpaceZoomCameraController) is public even though the release notes list four.panSpeed/inertiaEnabled/inertialDecay(map/elevator),dampingEnabled(tilt-orbit/zoom),angleThreshold+ nested controllers (hybrid).Scene.snapdefaults (width = 25,height = width), Model-pipeline-only scope, WebGL2EXT_color_buffer_floatrequirement, andSceneSnapResult = { object, position, screenPosition, isEdge }all match the shipped JSDoc.enablePickFeatures).Conflict handling vs main
mainmerged #24 (frame named targets with bounding spheres) after the eval branch forked; the camera skill here is a three-way merge that preserves both: #24'sflyToBoundingSpheretarget-framing guidance and quick-reference rows are intact, and the new Controller-framework note explicitly routes input-remap tasks back toScreenSpaceCameraController's*EventTypes.Evaluation evidence (feat/eval-and-optimization pipeline)
Vetted bytes == shipped bytes (the validated tree is byte-identical to this PR's
skills/).npm run gate, same script as eval-branch CI): PASS — evaluation + scenario manifests validate, skill contract passes for all 15 skills against the 582-symbol registry, 227 unit tests pass, deterministic fixture scorecard 100%, fixture polarity verification passes, canonical eval surface + tracked public surface scans pass.cesiumjs-camera/eval-006(aregression_critical: falsescenario) and it is environment-caused, control-proven: only its tile-settle/screenshot gates fail ("globe tiles still streaming" past the 45 s budget); its substantive checks (no_console_errors,code_runs, all pattern checks) pass on every roll. Re-rendering the byte-identical Aug-24 source that previously settled in 5–9 s fails the same way under the host load present during validation (load average 24–29 with an external Chrome pegging a core; SwiftShader tile generation is CPU-bound). Re-run on a quiet host to get 47/47.ERR_CERT_AUTHORITY_INVALIDblip, Ion preflight timeouts, and one codegen style roll that hoistedbaseLayerinto a variable) all pass on retry and are unrelated to skill wording.Wording hardening informed by eval evidence
rectanglegraphics where the contract expectspolygon): the hover recipe now pins graphics-type fidelity ("polygon over a region" ⇒ polygon graphics withPolygonHierarchy, not rectangle) and adds the entity material-swap variant.rotateEventTypes/tiltEventTypes/zoomEventTypescanonical for remap tasks, so the new controllers cannot misdirect them.baseLayer:layer hoisted into a variable — functionally identical); fresh roll passes. Flagged as a scenario-regex hardening opportunity on the eval branch (not a skills issue).Follow-ups (intentionally out of scope)
README.md,.claude-plugin/marketplace.json, anddocs/DOMAINS.mdstill say 1.143/~551 on main; a companion docs/metadata PR will bump them (content already prepared).Eval-branch companionDone:feat/eval-and-optimizationnow carries the 1.144 sync (7d95669), the wording corrections (6f20882), and an alignment commit (4d29273) making itsskills/byte-identical to this PR, so the operational eval branch renders baselines from the same wording that ships to main (pushed to origin).Reviewer checklist
KHR_mesh_primitive_restart