Closes #3333 When a dataset is accessed via anonymized private URL, w…#3335
Open
lbownik wants to merge 3 commits into
Open
Closes #3333 When a dataset is accessed via anonymized private URL, w…#3335lbownik wants to merge 3 commits into
lbownik wants to merge 3 commits into
Conversation
…e should not show empty metadata sections fixed and refactored template edition view
rscipien
reviewed
Jul 27, 2026
| return permissionsWrapper.notFound(); | ||
|
|
||
| final Optional<Dataverse> dataverse = this.dataverseRepo.findById(this.dataverseId); | ||
| if(! dataverse.isPresent()) { |
|
|
||
| private Template selectedTemplate = null; | ||
| private Map<MetadataBlock, List<DatasetFieldsOfType>> mdbForView; | ||
| private ViewTemplateDialog vieTemplateDialog = new ViewTemplateDialog(EMPTY, emptyList()); |
Contributor
There was a problem hiding this comment.
Typo in variable vieTemplateDialog -> viewTemplateDialog
| } | ||
|
|
||
| public boolean shouldRenderField(final int blockIndex, final int fieldOfTypeIndex) { | ||
| return !isViewedFromAnonymizedPrivateUrl() || |
Contributor
There was a problem hiding this comment.
is this correct check isViewedFromAnonymizedPrivateUrl
In shouldRenderField ther is negation of isViewedFromAnonymizedPrivateUrl
In shouldRenderBlock is oposit?
Contributor
Author
There was a problem hiding this comment.
it is correct - refactored logical expression to make it obvious that both methods use the same expression
rscipien
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e should not show empty metadata sections
fixed and refactored template edition view