Skip to content

3323 clone emails selectively - #3324

Merged
lbownik merged 7 commits into
developfrom
3323_clone_emails_selectively
Jul 8, 2026
Merged

3323 clone emails selectively#3324
lbownik merged 7 commits into
developfrom
3323_clone_emails_selectively

Conversation

@lbownik

@lbownik lbownik commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@lbownik
lbownik requested a review from rscipien July 7, 2026 10:27
mapping(Function.identity(), toList())));

fieldsByTypesMap.forEach((key, value) -> fieldsByTypes.add(new DatasetFieldsByType(key, value)));
System.gc();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intended?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

private void copyFields(final DatasetFieldsOfType fieldByType,
final List<DatasetField> sourceFields, final Dataset sourceDataset) {

final List<DatasetField> selectedCourceFields = sourceFields.stream().

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo selectedCourceFields -> selectedSourceFields

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed and refatored

fieldsOfType.type.name=='publication'}">
<div class="col-sm-3 control-label section-title">
#{fieldsByType.datasetFieldType.localeTitle}
#{fieldsOfType.datasetFieldType.localeTitle}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be changed to fieldsOfType.datasetFieldType to fieldsOfType.type

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actualy it should stay as #{fieldsByType.datasetFieldType.localeTitle}

fixed

@rscipien rscipien assigned lbownik and unassigned rscipien Jul 8, 2026
@lbownik
lbownik requested a review from rscipien July 8, 2026 07:47
@lbownik lbownik assigned rscipien and unassigned lbownik Jul 8, 2026
@rscipien rscipien assigned lbownik and unassigned rscipien Jul 8, 2026
@lbownik
lbownik force-pushed the 3323_clone_emails_selectively branch from 408dadf to 5ae0d50 Compare July 8, 2026 12:58
@lbownik
lbownik merged commit a9e3ca3 into develop Jul 8, 2026
1 check passed
@lbownik
lbownik deleted the 3323_clone_emails_selectively branch July 8, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants