feat(call): peer 'camera off' placeholder - #33
Merged
Conversation
…camera Before, if the peer turned their camera off their remote video just froze on the last frame. The peer already signals RemoteMuteChanged; surface it and show an honest placeholder. - call.rs: the call-lifecycle event for remote_mute_changed now carries remoteAudioMuted / remoteVideoMuted (present only for that kind). Borrowed match so the event isn't moved before describe(). - shell.html/css: a #camOff overlay (crossed-camera glyph + name) over the call video stage. - shell.js: remote_mute_changed toggles the placeholder on remoteVideoMuted and labels it with the peer's name; endCall clears it. Presentation-only — no media byte crosses in the lifecycle event (Inv 8). Verified: app cargo check + clippy -D warnings + fmt; node --check shell.js. On-device pending hardware. Author: sachin sarwa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the peer turns their camera off, their remote video used to just freeze on the last frame. The peer already sends
RemoteMuteChanged; this surfaces it as an honest "camera off" placeholder.What
call-lifecycleevent forremote_mute_changednow carriesremoteAudioMuted/remoteVideoMuted(present only for that kind; borrowed match so the event isn't moved beforedescribe()).#camOffoverlay (crossed-camera glyph + peer name) over the call-video stage.remote_mute_changedtoggles the placeholder onremoteVideoMuted, labels it with the peer's name, andendCallclears it.Security (unchanged)
Presentation-only — the lifecycle event carries no media byte, just the boolean mute state (Inv 8).
Verification
App
cargo check+clippy -D warnings+fmt;node --check shell.js. On-device pending hardware.