Repository navigation
Conversation
7fea741 to
751a55a
Compare
|
Maybe it's nostalgia, but the rounded buttons in the top bar makes it look less like a status bar. Maybe that's a good thing, as it signals that they can be clicked, but looks just a bit off to me. I'm not sure about the dropdown on the main burger menu (in the top right), it looks better than what we have now, but something doesn't look quite right. Maybe the spacing is too much? Else where the rounded buttons looks very nice! |
Hmm, I don't find it weird but I'll see if I can think of something else. I could add a way to configure their radius separately (currently they use
It may be the really thin border around the menu buttons? I added it because without it you could not distinguish the buttons from some elements behind them (for instance the screen select button). I'll also see if I can think of another design here. |
|
Pushed my last changes which update a few things on the bundled themes (see screenshots in the main post) and add a theme editor. I still left the PR as a draft because I've only tested the fonts customization on Linux and let's say it's probably the most annoying part of those changes... I didn't find anything in Kivy that would allow us to list available fonts easily so I had to do it manually which involves things that are quite specific to each OS. I'll try to do some tests on Windows and Android but will need help for this on Mac/iOS.
Smaller change but I also added a splitter between the MDI text input and list:
@SergeBakharev Regarding your previous points, I didn't change them (yet) in the default themes but added ways to:
|
|
I can help with the MacOS/iOS font code |
|
Font selection is now working fine on Android (at least on my tablet):
I also did some tests on Windows tonight and saw no issue there either. Pre-built binaries for the last commit ( |
…ization + various changes
005deca to
70a9d21
Compare





Summary
The theme editor allows to configure all the colors, grouped by categories as well as some fonts (the main one, one for the top bar indicators, and one for the gcode/mdi lists) and a few behaviors (such as coloring the jogging pads background/texts).
All themes are stored as JSON files that can extend a base theme.
For now only one theme can be saved as the customized version of a selected base theme. Ideally I would have liked to add an import/export feature but I prefer to wait for a good common save/load widget that would also work on iOS/Android and that we could use everywhere we need to (CMM/Backup/...). In the meantime the theme can be retrieved from the
themesfolder of the app dir (on Linux:~/.config/makera/themes/custom.json).Before starting this I also fixed a few things that annoyed me in the current UI (style inconsistencies, some things overflowing on smaller devices, etc.), so some elements are a bit different even in the base theme (that'll be called "Dark" from now on).
Some screenshots:
Theme editor:



Dark:



Light:



Monokai:



Nord:



Solarized Dark:



Solarized Light:



Also, an example of how the main screen now looks on a smaller screen (colors are not up-to-date with the latest Monokai theme, but that's not important here):

I tested this on Linux with my CA1 and used Cursor when developing it.
Contributor checklist
for the complete change.
poetry run pre-commit run --all-files) passes with no errors.