-
Notifications
You must be signed in to change notification settings - Fork 4
ticket #3 cs-assistant: Added :stats and verbose mode to the dev CLI #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
strictshot
wants to merge
2
commits into
main
Choose a base branch
from
feat/adding-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,24 @@ async def has_chunks(session: AsyncSession) -> bool: | |
| result = await session.execute(select(ChunkRow.id).limit(1)) | ||
| return result.scalar_one_or_none() is not None | ||
|
|
||
| @staticmethod | ||
| async def get_source_and_chunk_counts(session: AsyncSession) -> tuple[int, int]: | ||
| count_sources = await Repository.count_sources(session) | ||
| count_chunks = await Repository.count_chunks(session) | ||
| return count_sources, count_chunks | ||
|
|
||
| @staticmethod | ||
| async def count_chunks(session: AsyncSession) -> int: | ||
| result = await session.execute(select(func.count(ChunkRow.id))) | ||
| # if above doesn't work properly | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lines 26-27 look like temporary code that isn't needed since they're commented out? If yes, please remove them from the final PR. |
||
| # result = await session.execute(select(func.count().select_from(ChunkRow))) | ||
| return result.scalar_one() | ||
|
|
||
| @staticmethod | ||
| async def count_sources(session: AsyncSession) -> int: | ||
| result = await session.execute(select(func.count(SourceRow.id))) | ||
| return result.scalar_one() | ||
|
|
||
| @staticmethod | ||
| async def get_or_create_source( | ||
| session: AsyncSession, *, name: str, url: str, source_type: str | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These methods currently don't have tests, even though all other repository methods have tests implemented. For consistency, implement unit tests for these in
tests/infrastructure/db/test_repository.py.Follow the pattern / conventions of the other tests in that file. Run tests before committing to verify behaviour and that they pass.