fix: make the unknown target reason warning informative and rate-limited - #605
Merged
pisaiah merged 1 commit intoAug 25, 2026
Conversation
The warning fired with a bare stack trace on every setTarget call that had no mapped TargetReason, which can happen every tick for every mob and buries the log in identical lines. Log the mob type, uuid, world, position, old and new target plus the top caller frames instead, and report each (mob type, call site) pair only once per server run so new code paths are still surfaced without the spam. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mob#setTargetcalls that reachcardboard$setTargetwithout a mappedTargetReasonlog:with a bare
new Exception()stack trace. This can happen every tick for every mob, so the log fills with millions of identical lines and the stack traces make it worse rather than actionable.Change
cardboard$warnUnknownTargetReason, which reports the mob type, uuid, world, block position, old target and new target, plus the top 4 caller frames (our own mixin frames skipped).(mob type, call site)pair is reported only once per server run, so a genuinely new code path is still surfaced while the per-tick spam is gone.Example output:
Note (not addressed here)
setTargetCraftBukkitpasses the currenttargetfield instead of thelivingEntityargument tocardboard$setTarget, so the incoming target never reaches the event. That looks like a separate bug and is left untouched, since fixing it changes event behaviour.Testing
./gradlew compileJavapasses.