Skip to content

fix(ci): fix visual-diff workflow YAML and knip entry#2579

Open
riderx wants to merge 1 commit into
mainfrom
fix/visual-diff-ci
Open

fix(ci): fix visual-diff workflow YAML and knip entry#2579
riderx wants to merge 1 commit into
mainfrom
fix/visual-diff-ci

Conversation

@riderx

@riderx riderx commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary (AI generated)

  • Fix invalid YAML list syntax in .github/workflows/visual-diff.yml (pull_request.types entries were missing - prefixes)
  • Register playwright/visual-diff.config.ts as a knip entry so dynamic imports are not flagged as unused exports

Motivation (AI generated)

PR #2576 merged with a failing Check dead code job. Knip could not parse the workflow file and reported false unused exports after the visual-diff script switched to dynamic config loading.

Business Impact (AI generated)

Restores green CI on main and allows the visual-diff workflow to run correctly on future PRs labeled visual-change.

Test Plan (AI generated)

  • bun run lint:deadcode passes locally
  • CI run on feat/visual-diff-pr-tool at e8861b52b passed Check dead code

Generated with AI

Made with Cursor

Correct pull_request trigger types list syntax and register
visual-diff.config.ts as a knip entry so dynamic imports pass deadcode.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@riderx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 8 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: cc444040-9bae-4391-907e-dced9fb8b9ee

📥 Commits

Reviewing files that changed from the base of the PR and between 9a48e19 and 24920b1.

📒 Files selected for processing (2)
  • .github/workflows/visual-diff.yml
  • knip.json

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Cursor Bugbot check passed, but no Bugbot review comment (<!-- BUGBOT_REVIEW -->) was found on this PR, so I am not auto-approving. Requesting human review for this small CI/knip fix.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@cursor cursor Bot requested a review from WcaleNieWolny June 23, 2026 19:46
@codspeed-hq

codspeed-hq Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing fix/visual-diff-ci (24920b1) with main (9a48e19)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Cursor Bugbot passed with no issues, but the expected Bugbot review comment is missing on this PR, so I am not auto-approving. @WcaleNieWolny is already requested for human review of this CI/knip fix.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant