You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add daily global_stats counters for apps created, first-day CLI onboarding builds, and first-day manual builds.
Tag CLI native build requests as manual or cli_onboarding and normalize missing/unknown sources server-side.
Add an admin dashboard multi-line chart for the saved-by-day app creation/build onboarding metrics.
Screenshot
Validation
bun lint
bun lint:backend
bun typecheck
bun run cli:check
bun test tests/admin-stats.test.ts
bun test ./test/prescan/request-gate.test.ts from cli/
bun run supabase:db:reset
bunx supabase db lint --local from .context/supabase-worktrees/c85d6572 (exits 0 with existing warnings)
Captured the admin dashboard change as docs/pr-assets/admin-app-build-onboarding-chart.webp
Note
Medium Risk
Touches schema, migrations, and the daily global-stats shard with delayed cohort logic; mistakes would skew admin metrics but not user auth or billing.
Overview
Adds onboarding provenance on apps (created_from_onboarding, onboarding_completed_at via a trigger when need_onboarding flips off) and persists three daily global_stats counters: apps created that UTC day, CLI-onboarding apps with >2 builds in the first 24h (only if onboarding completed within 24h of creation), and non-onboarding apps with the same build threshold.
The global stats job computes those cohort metrics on a one-day lag so each app’s full 24h build window can finish, then writes them to the prior day’s snapshot. App create sets created_from_onboarding from need_onboarding. The admin dashboard gets a multi-line chart and trend API wiring; get_org_apps_with_last_upload is rewritten to an explicit column list so new app fields do not break the RPC contract. apps.vue normalizes list rows that omit the new columns.
Reviewed by Cursor Bugbot for commit 3712e7e. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
Added an admin dashboard chart for app build onboarding metrics, including total apps created and onboarding build counts within 24 hours (CLI vs manual).
Enhanced app tracking with onboarding provenance and completion timestamps.
Bug Fixes
Improved admin stats trend typing/serialization so onboarding metrics display correctly.
Tests
Added unit coverage for onboarding metrics summarization logic.
Chores
Updated translation strings to support the new onboarding chart labels.
Adds onboarding tracking to the app lifecycle: two new columns on public.apps (created_from_onboarding, onboarding_completed_at) with a trigger to auto-set the completion timestamp, three new daily global_stats metrics columns, a backend computation function wired into the core stats shard, an updated admin trend query, a new admin dashboard chart, and corresponding TypeScript type definition updates across all packages.
Changes
App Build Onboarding Metrics Pipeline
Layer / File(s)
Summary
Migration: apps onboarding columns, global_stats metrics, trigger, and RPC supabase/migrations/20260623144909_admin_app_build_onboarding_metrics.sql
Adds created_from_onboarding and onboarding_completed_at to public.apps with a trigger function that auto-sets completion on need_onboarding transition. Adds three new global_stats bigint metrics columns (apps_created, apps_with_cli_onboarding_builds_24h, apps_with_manual_builds_24h). Creates supporting indexes on public.apps(created_at) and public.build_requests(app_id, created_at). Rewrites/replaces get_org_apps_with_last_upload RPC with pagination, search, sorting, and a derived last_upload_at field computed from app_versions. Sets function ownership and grants.
Read replica and Drizzle schema updates read_replicate/schema_replicate.sql, supabase/functions/_backend/utils/postgres_schema.ts
Read-replica schema and Drizzle ORM schema are synchronized with the new apps onboarding columns and idx_apps_created_at index.
TypeScript type definitions across all packages src/types/supabase.types.ts, cli/src/types/supabase.types.ts, supabase/functions/_backend/utils/supabase.types.ts
All Supabase-generated type files updated: apps Row/Insert/Update gain created_from_onboarding and onboarding_completed_at; global_stats Row/Insert/Update gain the three new metrics counters; get_accessible_apps_for_apikey_v2 return type includes the onboarding fields.
App creation: persist created_from_onboarding from need_onboarding supabase/functions/_backend/public/app/post.ts
Sets created_from_onboarding from body.need_onboarding ?? false in the insert object and includes it in the SQL INSERT INTO public.apps column list and VALUES parameter array.
Onboarding metrics computation in logsnag_insights shard supabase/functions/_backend/triggers/logsnag_insights.ts
Adds DAY_IN_MS constant, summarizeAppBuildOnboardingRows helper that counts created apps and classifies CLI vs manual onboarding (when completion is within 24h of creation and build count exceeds 2), and getAppBuildOnboardingMetrics function querying prior-day apps joined with 24h-window build requests. runCoreGlobalStatsShard is updated to call this function and write the three new fields into updateGlobalStatsSnapshot. Exports the summarizer utility for testing.
Admin global stats trend query and interface supabase/functions/_backend/utils/pg.ts
AdminGlobalStatsTrend interface gains three new numeric fields. getAdminGlobalStatsTrend SQL selects them via JSON key lookups with safe casting to integers defaulting to 0. Result-row mapping populates these fields with || 0 fallbacks.
Admin dashboard onboarding chart and translations src/pages/admin/dashboard/index.vue, messages/en.json
Extends globalStatsTrendData type with the three new metrics fields. Adds appBuildOnboardingSeries computed property mapping trend data into three labeled chart series. Inserts a new ChartCard with AdminMultiLineChart into the template grid. Adds four i18n translation keys for chart title and metric labels.
apps.vue icon loader: AppIconSource union and onboarding field normalization src/pages/apps.vue
Introduces AppIconSource union type covering both base apps rows and RPC return rows. Adds normalizeAppRow helper to default missing onboarding fields. Updates appWithImmediateIcon and loadAppIcon/loadAppIcons to accept the union type, normalize input before signing, and update loading state on both success and failure.
Tests: admin stats trend and onboarding summarizer unit test tests/admin-stats.test.ts, tests/logsnag-insights-revenue.unit.test.ts
Admin stats test seeds the three new global_stats fields in trend fixtures and asserts the API response includes them. Local type assertion is extended to include the new counters. New assertions on latest trend row verify the new metrics values. New concurrent unit test exercises summarizeAppBuildOnboardingRows with mixed row types and timestamps across the 24h boundary; asserts exact summary counts.
Sequence Diagram
sequenceDiagram
participant User as User<br/>(creates app)
participant PostAPI as POST /app<br/>(create endpoint)
participant AppsDB as Apps table
participant Trigger as set_app_onboarding<br/>_completed_at trigger
participant CoreShard as Core global<br/>stats shard
participant GetMetrics as getAppBuild<br/>OnboardingMetrics
participant GlobalStatsDB as Global stats<br/>table
participant AdminDash as Admin<br/>Dashboard
User->>PostAPI: POST /app (need_onboarding=true)
PostAPI->>AppsDB: INSERT created_from_onboarding=true
AppsDB-->>PostAPI: app created
Note over CoreShard: Daily scheduled execution
CoreShard->>GetMetrics: Get prior-day metrics
GetMetrics->>AppsDB: Query apps with build requests
AppsDB-->>GetMetrics: rows with created_at, onboarding_completed_at, build_count
GetMetrics->>GetMetrics: summarizeAppBuildOnboardingRows
GetMetrics-->>CoreShard: apps_created, apps_with_cli/manual_onboarding_builds_24h
CoreShard->>GlobalStatsDB: Update global_stats snapshot
AdminDash->>GlobalStatsDB: Fetch trend data
GlobalStatsDB-->>AdminDash: global_stats trend rows
AdminDash->>AdminDash: appBuildOnboardingSeries mapper
AdminDash-->>User: Render onboarding metrics chart
Loading
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~60 minutes
Possibly related PRs
Cap-go/capgo#1834: Introduces need_onboarding in the same post.ts app creation endpoint that this PR extends to persist created_from_onboarding.
Cap-go/capgo#2484: Refactors the runCoreGlobalStatsShard snapshot pipeline in logsnag_insights.ts that this PR extends with the new onboarding metrics computation.
Cap-go/capgo#2509: Adds the cron job that flips apps.need_onboarding to false, directly triggering the onboarding_completed_at trigger introduced by this PR.
Suggested reviewers
Dalanir
WcaleNieWolny
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title clearly summarizes the main change: adding a chart to the admin dashboard that visualizes app creation and first-day build onboarding metrics.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Description check
✅ Passed
The PR description provides a clear summary, includes validation steps, and references a screenshot, but is missing the Test Plan section from the template.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
Comment @coderabbitai help to get the list of available commands.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot remained pending after the 8-minute polling window, so automated review is incomplete and I am not approving. Human review is needed for the migration, backend trigger, and admin dashboard changes.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/types/supabase.types.ts (1)
321-332: 🗄️ Data Integrity & Integration | 🟡 Minor
Update TypeScript RPC return types to reflect actual column availability.
The new created_from_onboarding and onboarding_completed_at columns are missing from the TypeScript type definitions for both RPC functions:
get_accessible_apps_for_apikey_v2 (line 3596): Returns full apps row at SQL level but TypeScript types omit the new fields, causing type-SQL mismatch.
get_org_apps_with_last_upload (line 3824): Intentionally excludes these fields (per SQL comment: "stable apps list contract"), so TypeScript correctly omits them—but this is by design.
The consumer code in src/pages/apps.vue:42-43 works around this with fallback logic ('created_from_onboarding' in app), but relying on runtime field presence is fragile. Regenerate the TypeScript types to match the SQL schema.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/types/supabase.types.ts` around lines 321 - 332, The TypeScript type
definitions in the Supabase types file for the RPC functions
`get_accessible_apps_for_apikey_v2` and `get_org_apps_with_last_upload` are out
of sync with the actual SQL schema. The `get_accessible_apps_for_apikey_v2`
function should include the `created_from_onboarding` and
`onboarding_completed_at` fields since it returns the full apps row at the SQL
level, while `get_org_apps_with_last_upload` should continue to exclude these
fields as per its design contract for a stable API. Regenerate the TypeScript
type definitions from the Supabase schema to ensure they accurately reflect what
each RPC function returns, eliminating the need for runtime field presence
checks in consumer code like `src/pages/apps.vue`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/types/supabase.types.ts`:
- Around line 321-332: The TypeScript type definitions in the Supabase types
file for the RPC functions `get_accessible_apps_for_apikey_v2` and
`get_org_apps_with_last_upload` are out of sync with the actual SQL schema. The
`get_accessible_apps_for_apikey_v2` function should include the
`created_from_onboarding` and `onboarding_completed_at` fields since it returns
the full apps row at the SQL level, while `get_org_apps_with_last_upload` should
continue to exclude these fields as per its design contract for a stable API.
Regenerate the TypeScript type definitions from the Supabase schema to ensure
they accurately reflect what each RPC function returns, eliminating the need for
runtime field presence checks in consumer code like `src/pages/apps.vue`.
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f35cf478-0df7-4267-872c-cdec0940988a
📥 Commits
Reviewing files that changed from the base of the PR and between 647bf87 and 09f48a1.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot is still pending after the 8-minute polling window and no Bugbot review comment was posted, so I am not approving without that automated signal. Human review is needed for the migration, backend metrics pipeline, and admin dashboard changes; WcaleNieWolny is already requested and I also requested Dalanir.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped status and no Bugbot review comment was posted, so I am not approving without that automated signal. Human review is still needed for the migration, backend metrics pipeline, and admin dashboard changes; WcaleNieWolny and Dalanir are already requested.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot finished with a skipped check and reported 2 unresolved findings (including one high-severity metrics timing issue), so I am not approving. WcaleNieWolny and Dalanir are already requested for human review of the migration, backend metrics pipeline, and admin dashboard changes.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@supabase/functions/_backend/triggers/logsnag_insights.ts`:
- Around line 1351-1392: The snapshot timing issue occurs because
getAppBuildOnboardingMetrics is being called too early in the day (01:01 UTC) to
capture the full 24-hour observation windows for apps created near the end of
the previous day. Find where getAppBuildOnboardingMetrics is invoked in the
snapshot recording workflow and delay the execution until after 23:59 UTC to
ensure all apps created the previous day have completed their full 24-hour build
observation window before the metric is recorded.
In `@supabase/migrations/20260623144909_admin_app_build_onboarding_metrics.sql`:
- Around line 48-52: The two CREATE INDEX statements for idx_apps_created_at and
idx_build_requests_app_created_at are missing the CONCURRENTLY keyword, which
will cause write locks on these tables during the migration. Add the
CONCURRENTLY keyword to both CREATE INDEX IF NOT EXISTS statements so that the
indexes are built without blocking concurrent write operations on the
public.apps and public.build_requests tables.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 037135c6-e2bc-4a1f-87b2-7c4102af84f8
📥 Commits
Reviewing files that changed from the base of the PR and between 09f48a1 and 22c3dc0.
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Use concurrent index creation to avoid deploy-time write blocking.
Line 48 and Line 51 create indexes without CONCURRENTLY. On large tables, this can block writes for the migration duration and degrade API availability. Move these to a dedicated migration that builds indexes concurrently.
Suggested change
-CREATE INDEX IF NOT EXISTS idx_apps_created_at-ON public.apps (created_at);--CREATE INDEX IF NOT EXISTS idx_build_requests_app_created_at-ON public.build_requests (app_id, created_at);+-- Run in a dedicated migration that supports non-transactional statements+CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_apps_created_at+ON public.apps (created_at);++CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_build_requests_app_created_at+ON public.build_requests (app_id, created_at);
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@supabase/migrations/20260623144909_admin_app_build_onboarding_metrics.sql`
around lines 48 - 52, The two CREATE INDEX statements for idx_apps_created_at
and idx_build_requests_app_created_at are missing the CONCURRENTLY keyword,
which will cause write locks on these tables during the migration. Add the
CONCURRENTLY keyword to both CREATE INDEX IF NOT EXISTS statements so that the
indexes are built without blocking concurrent write operations on the
public.apps and public.build_requests tables.
The reason will be displayed to describe this comment to others. Learn more.
CLI onboarding metrics misclassified
High Severity
The admin “CLI onboarding” series keys off created_from_onboarding, but that flag is only set when apps are created through the web app POST with need_onboarding. CLI build init / addAppInternal inserts apps without need_onboarding, so those apps stay created_from_onboarding: false and land in the manual series instead of CLI onboarding.
The reason will be displayed to describe this comment to others. Learn more.
Onboarding stats lag chart completion
Medium Severity
Daily onboarding counters for cohort date D are written when the core shard runs for date D+1, but the global_stats row for D can already satisfy completed_shards and appear in the admin trend after the D shard run, so apps_created and build onboarding fields can show as zero until the next day’s core job patches them.
The reason will be displayed to describe this comment to others. Learn more.
All build requests counted
Medium Severity
The onboarding cohort SQL counts every build_requests row in the first 24 hours with no status filter, while other global build stats in the same file count only status = 'succeeded', so failed or pending requests can push apps over the “>2 builds” threshold incorrectly.
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Cursor Bugbot finished with a skipped check and reported 3 unresolved findings (including high-severity metrics timing and CLI classification issues), so I am not approving. WcaleNieWolny and Dalanir are already requested for human review of the migration, backend metrics pipeline, and admin dashboard changes.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Cursor Bugbot finished with a skipped check and reported 3 unresolved findings (including a high-severity onboarding metrics issue), so I am not approving. WcaleNieWolny and Dalanir are already requested for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riderx
force-pushed
the
codex/admin-app-build-onboarding-metrics
branch
from
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
global_statscounters for apps created, first-day CLI onboarding builds, and first-day manual builds.manualorcli_onboardingand normalize missing/unknown sources server-side.Screenshot
Validation
bun lintbun lint:backendbun typecheckbun run cli:checkbun test tests/admin-stats.test.tsbun test ./test/prescan/request-gate.test.tsfromcli/bun run supabase:db:resetbunx supabase db lint --localfrom.context/supabase-worktrees/c85d6572(exits 0 with existing warnings)docs/pr-assets/admin-app-build-onboarding-chart.webpNote
Medium Risk
Touches schema, migrations, and the daily global-stats shard with delayed cohort logic; mistakes would skew admin metrics but not user auth or billing.
Overview
Adds onboarding provenance on apps (
created_from_onboarding,onboarding_completed_atvia a trigger whenneed_onboardingflips off) and persists three dailyglobal_statscounters: apps created that UTC day, CLI-onboarding apps with >2 builds in the first 24h (only if onboarding completed within 24h of creation), and non-onboarding apps with the same build threshold.The global stats job computes those cohort metrics on a one-day lag so each app’s full 24h build window can finish, then writes them to the prior day’s snapshot. App create sets
created_from_onboardingfromneed_onboarding. The admin dashboard gets a multi-line chart and trend API wiring;get_org_apps_with_last_uploadis rewritten to an explicit column list so new app fields do not break the RPC contract.apps.vuenormalizes list rows that omit the new columns.Reviewed by Cursor Bugbot for commit 3712e7e. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit