Skip to content

Scale the edge budget with the page count - #75

Merged
arberx merged 1 commit into
mainfrom
fix/scale-edge-budget
Aug 28, 2026
Merged

arberx merged 1 commit into
mainfrom
fix/scale-edge-budget

Conversation

@arberx

@arberx arberx commented Aug 28, 2026

Copy link
Copy Markdown
Member

7.0.0 made maxPages the budget that drives the others, but left maxEdges flat at 100,000. On link-dense sites that recreates the truncation one budget over: measured at ~42 recorded edges per page on a production portfolio site (navigation and footer templates repeat on every page), the flat default runs out near page 2,400 of a 5,000-page request and admission stops with termination max-edges.

An unset maxEdges now derives as maxPages x 50, floored at the flat default and clamped to a safe integer:

maxPages maxEdges before after
unset 100,000 100,000
100 100,000 100,000 (floor)
5,000 100,000 250,000
8,700 100,000 435,000

An explicit maxEdges is honoured exactly. The regression test fails with the scaling removed (verified by reverting). 625 tests pass; typecheck, lint, e2e clean.

Minor bump 7.0.0 to 7.1.0; crawl engine 2.1.0 to 2.2.0 (shape unchanged, semantics changed).

🤖 Generated with Claude Code

@arberx
arberx force-pushed the fix/scale-edge-budget branch from f5f353c to 6345f0f Compare August 28, 2026 18:05
7.0.0 derived maxFetches, maxDurationMs and maxBytes from maxPages but left
maxEdges at its flat 100,000 default, recreating the original defect one
budget over: at the ~42 recorded edges per page measured on a production
portfolio site, a 5,000-page request stops admitting pages near 2,400 with
termination max-edges.

An unset maxEdges now derives as maxPages x 50, floored at the flat default
and clamped to a safe integer. An explicit maxEdges is honoured exactly and
a call with no maxPages keeps the documented flat default. Engine 2.1.0 to
2.2.0: shape unchanged, semantics changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@arberx
arberx force-pushed the fix/scale-edge-budget branch from 6345f0f to 782afb9 Compare August 28, 2026 18:05
@arberx
arberx merged commit 2a64525 into main Aug 28, 2026
4 checks passed
@arberx
arberx deleted the fix/scale-edge-budget branch September 13, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant