Skip to content

refactor(core): derive Default for CubeQuery #2722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goldmedal wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −12
Open

refactor(core): derive Default for CubeQuery #2722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions core/wren-core/core/src/mdl/cube.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ use serde::{Deserialize, Serialize};
use crate::mdl::manifest::{Cube, CubeDimension, Manifest, Measure, TimeDimension};

/// A structured cube query — the input to [`cube_query_to_sql`].
#[derive(Debug, Clone, Serialize, Deserialize)]
///
/// Every field satisfies [`Default`], so callers should use struct-update
/// syntax (`..Default::default()`) and only name the fields they care about.
/// New optional fields can then be added without breaking downstream code.
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct CubeQuery {
pub cube: String,
Expand Down Expand Up @@ -647,13 +651,7 @@ mod tests {
fn query(cube: &str) -> CubeQuery {
CubeQuery {
cube: cube.to_string(),
measures: vec![],
dimensions: vec![],
time_dimensions: vec![],
filters: vec![],
order_by: vec![],
limit: None,
offset: None,
..Default::default()
}
}

Expand Down
5 changes: 1 addition & 4 deletions core/wren-core/core/tests/cube_public_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,11 @@ fn cube_query_public_order_by_types_generate_sql_without_a_limit() {
cube: "OrdersCube".to_string(),
measures: vec!["revenue".to_string()],
dimensions: vec!["status".to_string()],
time_dimensions: vec![],
filters: vec![],
order_by: vec![CubeOrderBy {
member: "revenue".to_string(),
direction: SortDirection::Desc,
}],
limit: None,
offset: None,
..Default::default()
};

assert_eq!(
Expand Down
Loading