Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 115 additions & 1 deletion core/wren-core-py/tests/test_cube.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import json

import pytest

from wren_core import cube_query_to_sql

MANIFEST = json.dumps(
Expand Down Expand Up @@ -56,6 +55,43 @@
}
)

ORDERING_MANIFEST = json.dumps(
{
"catalog": "test",
"schema": "public",
"models": [
{
"name": "orders",
"tableReference": {"schema": "main", "table": "orders"},
"columns": [
{"name": "net_spend", "type": "double"},
{"name": "merchant_name", "type": "varchar"},
],
}
],
"cubes": [
{
"name": "order_metrics",
"baseObject": "orders",
"measures": [
{
"name": "net_spend",
"expression": "SUM(net_spend)",
"type": "DOUBLE",
}
],
"dimensions": [
{
"name": "merchant_name",
"expression": "merchant_name",
"type": "VARCHAR",
}
],
}
],
}
)


def test_basic_cube_query():
query = json.dumps(
Expand Down Expand Up @@ -140,3 +176,81 @@ def test_invalid_manifest_json():
query = json.dumps({"cube": "order_metrics", "measures": ["revenue"]})
with pytest.raises(ValueError, match="Invalid manifest JSON"):
cube_query_to_sql(query, "not json")


def test_order_by_uses_native_selected_ordinals_without_a_wrapper():
query = json.dumps(
{
"cube": "order_metrics",
"measures": ["net_spend"],
"dimensions": ["merchant_name"],
"orderBy": [
{"member": "net_spend", "direction": "desc"},
{"member": "merchant_name", "direction": "asc"},
],
"limit": 5,
}
)

assert cube_query_to_sql(query, ORDERING_MANIFEST) == (
"SELECT merchant_name AS merchant_name, SUM(net_spend) AS net_spend "
"FROM orders GROUP BY 1 ORDER BY 2 DESC, 1 ASC LIMIT 5"
)


@pytest.mark.parametrize(
("order_by", "message"),
[
(
[{"member": "not_selected", "direction": "desc"}],
"Cannot order by member 'not_selected': member is not selected by the query",
),
(
[
{"member": "net_spend", "direction": "desc"},
{"member": "net_spend", "direction": "asc"},
],
"Cannot order by member 'net_spend' more than once",
),
],
)
def test_order_by_rejects_unknown_and_duplicate_members(order_by, message):
query = json.dumps(
{
"cube": "order_metrics",
"measures": ["net_spend"],
"orderBy": order_by,
}
)

with pytest.raises(ValueError, match=message):
cube_query_to_sql(query, ORDERING_MANIFEST)


def test_order_by_rejects_non_lowercase_direction():
query = json.dumps(
{
"cube": "order_metrics",
"measures": ["net_spend"],
"orderBy": [{"member": "net_spend", "direction": "DESC"}],
}
)

with pytest.raises(ValueError, match="Invalid CubeQuery JSON"):
cube_query_to_sql(query, ORDERING_MANIFEST)


def test_order_by_without_selected_members_is_rejected():
query = json.dumps(
{
"cube": "order_metrics",
"measures": [],
"orderBy": [{"member": "net_spend", "direction": "desc"}],
}
)

with pytest.raises(
ValueError,
match="must include at least one measure, dimension, or time dimension",
):
cube_query_to_sql(query, ORDERING_MANIFEST)
Loading
Loading