Skip to content

fix: allow trusted proxies to bypass geoblocking#11

Open
CangioUni wants to merge 1 commit into
mainfrom
fix-trusted-proxies-bypass-3442144762289795279
Open

fix: allow trusted proxies to bypass geoblocking#11
CangioUni wants to merge 1 commit into
mainfrom
fix-trusted-proxies-bypass-3442144762289795279

Conversation

@CangioUni

Copy link
Copy Markdown
Owner

Modify ServeHTTP to bypass geoblocking for requests originating directly from IPs configured in trustedProxies. Previously, local IPs matching a trusted proxy were being blocked with a "PRIVATE" location. This ensures trusted IPs are always allowed. Adds a unit test to verify this logic.


PR created automatically by Jules for task 3442144762289795279 started by @CangioUni

Modify `ServeHTTP` to bypass geoblocking for requests originating directly from IPs configured in `trustedProxies`. Previously, local IPs matching a trusted proxy were being blocked with a "PRIVATE" location. This ensures trusted IPs are always allowed.

Adds a test `TestServeHTTPTrustedProxyBypass` to verify this behavior.

Co-authored-by: CangioUni <225256392+CangioUni@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant