Skip to content

Fixed a typo in the export modal, edited package.json, updated readme#169

Open
hobbsythe6th wants to merge 15 commits into
Candlestickers:developmentfrom
hobbsythe6th:development
Open

Fixed a typo in the export modal, edited package.json, updated readme#169
hobbsythe6th wants to merge 15 commits into
Candlestickers:developmentfrom
hobbsythe6th:development

Conversation

@hobbsythe6th

@hobbsythe6th hobbsythe6th commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

EDIT: I also added a script to run npm start and build-enggine together because MAN do I hate having to run two different commands. I also updated the readme a bit
Obviously I still kept the old scripts don't worry

@BaronAWC BaronAWC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json appears to have weird merge artifacts, so that should be fixed. everything else looks good

Comment thread jsconfig.json Outdated
Comment thread package-lock.json Outdated
Comment thread package-lock.json Outdated
Comment thread package-lock.json Outdated
@Alani25

Alani25 commented Jul 6, 2026

Copy link
Copy Markdown
Member

actually I believe baseUrl issue comes from the url-parse library and isn't being used anywhere, it's just included in the credits along with 7 other dependencies .
a lotta "zombies" :P the walking packages, now in theaters (aka your terminal window).

I was working on updating the packages on a separate branch, I was able to take out a few unused ones and update a few minor ones and have solved most of the depreciation warnings.
I don't think we want to just ignore the depreciation warnings as that may come back to bite us further down the road

I apologize but it seems we might be working on similar things and that might be a result of a lack of communication— but I do highly appreciate the efforts. If you're on discord per chance we can add you to where we discuss updates so you have a good idea of what's currently being covered by whom, and if not no worries

Comment thread src/Editor/Modals/ExportOptions/ExportOptions.jsx
@hobbsythe6th hobbsythe6th changed the title Fixed a typo in the export modal, made VS Code ignore a jsconfig deprecation warning, removed build-engine-windows (again), and updated package-lock Fixed a typo in the export modal, made VS Code ignore a jsconfig deprecation warning, edited package.json, and updated package-lock Jul 6, 2026
@hobbsythe6th hobbsythe6th changed the title Fixed a typo in the export modal, made VS Code ignore a jsconfig deprecation warning, edited package.json, and updated package-lock Fixed a typo in the export modal, made VS Code ignore a jsconfig deprecation warning, edited package.json, updated package-lock and readme Jul 6, 2026

@InternetAstronaut InternetAstronaut left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the deprecation ignores aren't needed, and we should just remove the baseUrl key. Unless we configure VSCode to use TS6 forever, since it defaults to using the one that came with it, or the one installed globally.

@hobbsythe6th

Copy link
Copy Markdown
Contributor Author

I think package-lock is fixed now

@InternetAstronaut InternetAstronaut left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package locks aren't important for me to review. I still request that both deprecation ignorations and base URL settings should be removed.

@Alani25

Alani25 commented Jul 7, 2026

Copy link
Copy Markdown
Member

actually I believe baseUrl issue comes from the url-parse library and isn't being used anywhere, it's just included in the credits along with 7 other dependencies . a lotta "zombies" :P the walking packages, now in theaters (aka your terminal window).

I was working on updating the packages on a separate branch, I was able to take out a few unused ones and update a few minor ones and have solved most of the depreciation warnings. I don't think we want to just ignore the depreciation warnings as that may come back to bite us further down the road

I apologize but it seems we might be working on similar things and that might be a result of a lack of communication— but I do highly appreciate the efforts. If you're on discord per chance we can add you to where we discuss updates so you have a good idea of what's currently being covered by whom, and if not no worries

Please refer back to this reply and see my other branch where I'm narrowing down the dependencies, so you don't end up doing the same work I've already done.
https://github.com/Candlestickers/Candlestick/tree/alani-node24-upgrade

image I've looked into all of the packages, their most up-to-date react 16 compatible versions, alternatives, and usage I don't mean to sound disrespectful, we really appreciate the work you've done @hobbsythe6th , but I don't want you to waste your time working on something that's already been done. If you have a discord account, or some form of preferred communication method, I wouldn't mind working together to help nail down all of the lacking dependencies.

@hobbsythe6th

Copy link
Copy Markdown
Contributor Author

I barely understand dependencies, but i'll remove the unnecessary stuff from here

@hobbsythe6th hobbsythe6th changed the title Fixed a typo in the export modal, made VS Code ignore a jsconfig deprecation warning, edited package.json, updated package-lock and readme Fixed a typo in the export modal, edited package.json, updated readme Jul 9, 2026
@hobbsythe6th hobbsythe6th requested a review from Alani25 July 10, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants