Fixed a typo in the export modal, edited package.json, updated readme#169
Fixed a typo in the export modal, edited package.json, updated readme#169hobbsythe6th wants to merge 15 commits into
Conversation
BaronAWC
left a comment
There was a problem hiding this comment.
package-lock.json appears to have weird merge artifacts, so that should be fixed. everything else looks good
|
actually I believe baseUrl issue comes from the I was working on updating the packages on a separate branch, I was able to take out a few unused ones and update a few minor ones and have solved most of the depreciation warnings. I apologize but it seems we might be working on similar things and that might be a result of a lack of communication— but I do highly appreciate the efforts. If you're on discord per chance we can add you to where we discuss updates so you have a good idea of what's currently being covered by whom, and if not no worries |
InternetAstronaut
left a comment
There was a problem hiding this comment.
In general, the deprecation ignores aren't needed, and we should just remove the baseUrl key. Unless we configure VSCode to use TS6 forever, since it defaults to using the one that came with it, or the one installed globally.
|
I think package-lock is fixed now |
InternetAstronaut
left a comment
There was a problem hiding this comment.
Package locks aren't important for me to review. I still request that both deprecation ignorations and base URL settings should be removed.
Please refer back to this reply and see my other branch where I'm narrowing down the dependencies, so you don't end up doing the same work I've already done.
I've looked into all of the packages, their most up-to-date react 16 compatible versions, alternatives, and usage
I don't mean to sound disrespectful, we really appreciate the work you've done @hobbsythe6th , but I don't want you to waste your time working on something that's already been done.
If you have a discord account, or some form of preferred communication method, I wouldn't mind working together to help nail down all of the lacking dependencies.
|
|
I barely understand dependencies, but i'll remove the unnecessary stuff from here |

EDIT: I also added a script to run npm start and build-enggine together because MAN do I hate having to run two different commands. I also updated the readme a bit
Obviously I still kept the old scripts don't worry