This repository was archived by the owner on Apr 26, 2026. It is now read-only.
Fix integration tests for extension/skin enable/disable - #737
Merged
Conversation
The TestExtensionSkin_EnableDisable test was failing in CI because the siteinfo API query returned readapidenied on the private-by-default test wiki, and the old fixed-sleep probing masked the failure for disable cases (an empty response matched the "not present" expectation). Two changes: - Add zz-test-public.php to the instance's config/settings/global/ so anonymous reads are allowed, letting the siteinfo API respond normally. - Replace Sleep + bounded-retry probes with waitForExtensionState / waitForSkinState helpers that poll until the expected state is observed or a 2-minute timeout elapses.
yaronkoren
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zz-test-public.phpinconfig/settings/global/, so the siteinfo API answers anonymous queries instead of returningreadapidenied.Sleep+ bounded-retry probe withwaitForExtensionState/waitForSkinStatehelpers that poll until the expected state is observed (2 min timeout). This also catches silent disable false-positives that the old probe masked when the API returned an error body.Test plan
go test -tags=integration -run TestExtensionSkin_EnableDisable ./tests/integrationpasses locally (~60s)