Open the gallery for a lone photo on the map - #72
Merged
Merged
Conversation
A photo marker used to open the attachment sheet when it held one picture and the gallery when it held several. Which of the two a mark holds depends on the zoom, since clusterPhotos gathers in screen pixels, so the same photograph opened different things depending on how far out the map was, and a lone picture could not be seen full screen without going through the sheet. Every photo marker now opens the gallery; the sheet, with the position controls, stays behind the gallery's menu. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a photo on the trip map now always opens the gallery, including when the marker holds a single picture.
Before, one picture opened
AttachmentSheetand several opened the gallery. Whether a marker holds one or several depends on the zoom (clusterPhotosgathers in screen pixels), so the same photograph opened different things depending on how far out the map was, and a lone picture was capped at a third of the screen. The sheet with the position controls is still one tap away behind the gallery's ⋮.trip_map_screen.dart: drop the single-photo branch in_showPhotosGalleryScreen, notAttachmentSheet(fails on the old code)docs/features.md, CHANGELOG updated🤖 Generated with Claude Code