Let a placed handover be moved before the rest are placed - #71
Merged
Merged
Conversation
Importing a recording across several entries asks for each handover in turn, and every tap placed the next open one, so a handover placed badly could only be corrected once all the others were placed, and then via "the nearest one", which could be its neighbour. Now one rule holds throughout: a tap places the selected handover. The selection is a numbered chip under the map, matched by a larger numbered mark on it; it advances to the next open handover after a tap and stays put once none is open, so a second tap refines the one just placed. Snapping keeps a handover between the nearest placed ones on either side, since the one next to it may now still be open. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a recording is imported across several entries, the screen asks for each handover in turn. Until now every tap placed the next open handover, so a badly placed one could only be corrected after all the others were placed, and then only through "move the nearest", which could pick its neighbour.
Change
One rule throughout: a tap on the map places the selected handover.
The selection lives in the panel, not on the map: tappable marks were tried before and lose the gesture arena to flutter_map's own
onTap.Tests
Two new widget tests in
test/track_import_screen_test.dart: moving handover 1 while handover 2 is still open, and refining the last placed handover after all are placed.flutter analyzeis clean; the full suite passes. Not yet tried on a device.Docs:
AGENTS.md,docs/features.md,CHANGELOG.md.🤖 Generated with Claude Code