Give the CI build its own Windows icon, and pin Flutter once per workflow - #69
Merged
Merged
Conversation
…flow The side-by-side Windows build was distinguishable only by its window title. build_ci_icon.py now also writes app_icon_ci.ico, which Runner.rc picks under PAPPUS_SIDE_BY_SIDE, cropped to the drawing because a desktop icon has no launcher mask to leave room for. The Flutter version was repeated four times in ci.yml and three times in release.yml, where a bump reaching some of them would have jobs building against different SDKs. It is one `env:` per workflow now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aquasolterra
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things, both from the Linux/Windows packaging work.
The Windows CI build had no icon of its own
It was distinguishable from the released app only by its window title.
tool/build_ci_icon.py— which already composes the mark with an amberCIchip for Android — now also writeswindows/runner/resources/app_icon_ci.ico, andRunner.rcpicks it underPAPPUS_SIDE_BY_SIDE.The Flutter version was pinned seven times
Four times in
ci.yml, three inrelease.yml. A bump that reached some of them would leave jobs testing and building against different SDKs. It is now oneenv:per workflow, and the reasoning about the range (3.47.x) versus the exact pin (3.47.2, the line an F-Droid recipe reads) moved up there with it.Verified
ci.yml, whilerelease.ymlneeds a dry run.🤖 Generated with Claude Code