Skip to content

Give the CI build its own Windows icon, and pin Flutter once per workflow - #69

Merged
aquasolterra merged 1 commit into
mainfrom
ci-housekeeping
Sep 15, 2026
Merged

aquasolterra merged 1 commit into
mainfrom
ci-housekeeping

Conversation

@JoshuaLampert

Copy link
Copy Markdown
Contributor

Two small things, both from the Linux/Windows packaging work.

The Windows CI build had no icon of its own

It was distinguishable from the released app only by its window title. tool/build_ci_icon.py — which already composes the mark with an amber CI chip for Android — now also writes windows/runner/resources/app_icon_ci.ico, and Runner.rc picks it under PAPPUS_SIDE_BY_SIDE.

  • Cropped to what is actually drawn: the adaptive icon's canvas is mostly the margin a launcher mask needs, and a desktop icon has no mask, so uncropped the mark would sit small in its own box on the taskbar.
  • Every size Windows asks for (16 … 256) in the one file, since it scales whatever it does not find, and a blurred 256 is what a 16px taskbar icon then looks like.
  • The Android files it writes come out byte-identical, so re-running the script changes only the new file.

The Flutter version was pinned seven times

Four times in ci.yml, three in release.yml. A bump that reached some of them would leave jobs testing and building against different SDKs. It is now one env: per workflow, and the reasoning about the range (3.47.x) versus the exact pin (3.47.2, the line an F-Droid recipe reads) moved up there with it.

Verified

  • The icon renders as intended at 128px, and the file carries all seven sizes.
  • Both workflows still parse.
  • Not verified: the icon on a real taskbar, and the workflows themselves — this PR's run is that test for ci.yml, while release.yml needs a dry run.

🤖 Generated with Claude Code

…flow

The side-by-side Windows build was distinguishable only by its window title.
build_ci_icon.py now also writes app_icon_ci.ico, which Runner.rc picks under
PAPPUS_SIDE_BY_SIDE, cropped to the drawing because a desktop icon has no
launcher mask to leave room for.

The Flutter version was repeated four times in ci.yml and three times in
release.yml, where a bump reaching some of them would have jobs building
against different SDKs. It is one `env:` per workflow now.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@aquasolterra
aquasolterra merged commit 0810ccf into main Sep 15, 2026
5 checks passed
@aquasolterra
aquasolterra deleted the ci-housekeeping branch September 15, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants