Prepare release 1.11.4 - #55
Merged
Merged
Conversation
Verified locally with fdroidserver 2.4.2: all three ABIs reproduce the published APK byte for byte, and all three carry only 0x7109871A (signature scheme v2) and 0x42726577 (verity padding) in their signing block -- the two checks are separate questions, which is what let the dependency metadata through last time. The gap between built and signed APK is 4096 bytes now rather than 12288, which is that block gone.
Two of the three comments on fdroiddata!47901. The first, dropping the Schedule category, was applied on the merge request itself; the recipe copy here had drifted and is brought back in line. Author info is AuthorName/AuthorEmail/AuthorWebSite, placed where yaml_app_field_order puts them. There is no separate project website, so no WebSite. The version code scheme is the interesting one. F-Droid asks Flutter apps for `build number * 10 + 1|2|3` instead of Flutter's own `1|2|4 * 1000 + build number`, so `abiCodes` in android/app/build.gradle.kts now overrides each split's versionCodeOverride. Measured rather than assumed: this block runs after Flutter's, so ours wins, and AGP 9.3.2 still carries the old variant API the snippet needs. The sharp edge is that the new scheme counts *smaller*. At build 15 it gives 151/152/153 where the published APKs are 1015/2015/4015, and Android refuses an update numbered below the installed one -- everyone holding a GitHub APK would have been stranded. Hence the build number jumps to 402, which is the first value putting all three above their predecessors (4021/4022/4023, built and read back off the APKs). A version code may only ever grow, so AGENTS.md records why 402 is not an arbitrary number. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From F-Droid review.