115 refactor fetchparams / Fix Invalid builder behaviour - #118
Merged
Conversation
dhonig
commented
Apr 20, 2025
dhonig
commented
Collaborator
- Introduce factory method with params for FetchParams
- Ensure that FetchParams are used for initialization so that we honor the builders fluent interface.
- Add tests showing that fetch params are set from the ConsumerGroupBuilder
…d. do not store fetch params in memory. instead call the factorymethod from the context where needed.
Closed
hgm-king
approved these changes
Apr 22, 2025
hgm-king
left a comment
hgm-king
left a comment
Collaborator
There was a problem hiding this comment.
I like this a lot better, youre right the fetch params were duplicated so breaking it down to only hold one copy is ideal
Collaborator
Author
|
@hgm-king I think we need to bump the version in accordance with accepted semantic versioning practices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.