Code review two feedback comments

client/components/FeaturedProduct.js

@@ -13,6 +13,10 @@ class FeaturedProduct extends Component {
       loading: true
     }
   }
+  // OB/LM: you can do
+  /*
+  state = {products: [], loading: true}
+  */
 
   async componentDidMount() {
     try {

client/components/HomePage.js

@@ -17,6 +17,7 @@ import {
 } from 'semantic-ui-react'
 import {NavLink} from 'react-router-dom'
 
+// OB/LM: listen to linter
 const getWidth = () => {
   const isSSR = typeof window === 'undefined'
 

client/components/ProductCard.js

@@ -6,6 +6,7 @@ import axios from 'axios'
 import {Button, Icon, Item, Label} from 'semantic-ui-react'
 import ReactHtmlParser from 'react-html-parser'
 
+// OB/LM: could make for a good test (especially if you separate out the local storage stuff)
 const addToCart = async (product, setCartSize, user) => {
   const currentItems = JSON.parse(localStorage.getItem('cart'))
 

client/components/Profile.js

@@ -49,6 +49,7 @@ class Profile extends React.Component {
                           key: orderNumber,
                           title: orderNumber,
                           content: {
+                            // Maybe could be <OrderTable {...} />
                             content: orderTable(order.id, products, totalPrice)
                           }
                         }
@@ -86,6 +87,7 @@ const orderTable = (id, products, totalPrice) => {
         </Table.Row>
       </Table.Header>
       <Table.Body>
+        {/* OB/LM: maybe group by product id before mapping */}
         {products.map((product, idx) => {
           totalPrice += product.price
           return (

client/store/index.js

@@ -6,6 +6,7 @@ import user from './user'
 import cart from './cart'
 import checkout from './checkout'
 
+// OB/LM: redux middleware for persisting cart to `localStorage` (could help reduce "multiple update" issues)
 const reducer = combineReducers({user, cart, checkout})
 const middleware = composeWithDevTools(
   applyMiddleware(thunkMiddleware, createLogger({collapsed: true}))

server/api/payment.js

@@ -17,6 +17,7 @@ const paymentApi = app => {
   })
 
   app.post('/', (req, res) => {
+    // OB/LM: client can define charge amount (not good), sanitize the request body (recommend util method for this)
     stripe.charges.create(req.body, postStripeCharge(res))
   })
 

server/api/users.js

@@ -21,6 +21,7 @@ router.get('/', async (req, res, next) => {
       next(err)
     }
   }
+  // OB/LM: missing else
 })
 
 // GET api/users/:id
@@ -69,8 +70,10 @@ router.put('/:id/cart', checkUser, async (req, res, next) => {
       orderData: req.body.products,
       completed: !!req.body.completed
     })
+    // OB/LM: consider moving the innards of the POST logic below to here (detect if a new cart needs to be made and make it)
     res.sendStatus(201)
   } catch (error) {
+    // OB/LM: firewood here, burn it
     console.log('PUT CART ERROR')
     next(error)
   }
@@ -93,8 +96,10 @@ router.post('/:id/cart', checkUser, async (req, res, next) => {
 // POST /api/users/guestCheckout
 // saves a completed guest order in DB with userId null
 
+// OB/LM: could be a POST /api/orders instead (more RESTful)
 router.post('/guestCheckout', async (req, res, next) => {
   try {
+    // OB/LM: web security issue, client can define the price of the order, maybe you want a method to calculate it
     await Order.create(req.body)
     res.sendStatus(201)
   } catch (error) {

server/db/models/order.js

@@ -26,6 +26,7 @@ const Order = db.define(
   },
   {
     hooks: {
+      // OB/LM: recommend a setter method instead of a hook
       beforeValidate: function(order) {
         if (typeof order.orderData !== 'string') {
           order.orderData = JSON.stringify(order.orderData)