Skip to content

Jhx set - #12

Open
F-TD5X wants to merge 10 commits into
masterfrom
jhx_Set
Open

Jhx set#12
F-TD5X wants to merge 10 commits into
masterfrom
jhx_Set

Conversation

@F-TD5X

@F-TD5X F-TD5X commented Jun 5, 2018

Copy link
Copy Markdown
Contributor

Complete basic functions
based on local Rb_tree branch, I will submit a pr later.
complete and tested function list:

insert()
lower_bound()
upper_bound()
find()
size()
max_size()
swap()
equal_range()
erase()
clear()
empty()
and construct/copy function

F-TD5X added 8 commits May 17, 2018 13:14
@F-TD5X
add function
5dc823b 
insert_unique(iterator __first, iterator __last)
@F-TD5X
update
3267b8f
@F-TD5X
add test
0906d1f 
add copy construct test
@F-TD5X
fix swap
ebf146f
@F-TD5X
update
4e9d10a
@F-TD5X
add test
e5b8f27 
add copy construct test
@F-TD5X
temp
cb4f87a
@F-TD5X
merge origin with local
7e70e4f
@F-TD5X
F-TD5X requested review from TanYz04, wenpen and zhuyutian57 June 5, 2018 13:44
@F-TD5X F-TD5X self-assigned this Jun 5, 2018
@F-TD5X F-TD5X added the enhancement New feature or request label Jun 5, 2018
@F-TD5X

F-TD5X commented Jun 5, 2018

Copy link
Copy Markdown
Contributor Author

鬼知道这代码咋就过于复杂了，简化不能。。。

zhuyutian57
zhuyutian57 requested changes Jun 13, 2018
View reviewed changes

@zhuyutian57 zhuyutian57 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一堆std是怎么回事？懒？

Comment thread Source/header/set.h

namespace custl {

template <typename _Key, typename _Compare = std::less<_Key>,

@zhuyutian57 zhuyutian57 Jun 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std是什么鬼

Comment thread Source/header/set.h Outdated
typedef typename _Rep_type::const_iterator const_iterator;
typedef typename _Rep_type::size_type size_type;
typedef typename _Rep_type::difference_type difference_type;
typedef typename _Rep_type::allocator_type allocator_type;

@zhuyutian57 zhuyutian57 Jun 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进跟需要跟其他文件一样

@F-TD5X F-TD5X Jun 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

事实上这里的缩进本来是一个TAB，但按照 Google Code Style 就变成空格了。。

@PonyXiaopeng PonyXiaopeng Jun 14, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@F-TD5X 这个wiki已经说过了，仔细读下

Comment thread Source/header/tree.h
swap(_M_key_compare, __t._M_key_compare);
std::swap(_M_header, __t._M_header);
std::swap(_M_node_count, __t._M_node_count);
std::swap(_M_key_compare, __t._M_key_compare);

@zhuyutian57 zhuyutian57 Jun 13, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std？

@F-TD5X F-TD5X Jun 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std废话啊。。。又没人写 stl_utility 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuyutian57 zhuyutian57 zhuyutian57 approved these changes
@wenpen wenpen Awaiting requested review from wenpen
@TanYz04 TanYz04 Awaiting requested review from TanYz04
+1 more reviewer
@PonyXiaopeng PonyXiaopeng PonyXiaopeng left review comments
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@F-TD5X F-TD5X

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@F-TD5X @zhuyutian57 @PonyXiaopeng