Skip to content

Things I needed to get this to compile#287

Open
krugar wants to merge 2 commits into
CUModSquad:masterfrom
krugar:scss-import-hack
Open

Things I needed to get this to compile#287
krugar wants to merge 2 commits into
CUModSquad:masterfrom
krugar:scss-import-hack

Conversation

@krugar

@krugar krugar commented Nov 6, 2019

Copy link
Copy Markdown

Additionally to what's in the PR,

I had to manually run npm i --save @csegames/camelot-unchained in Camelot-Unchained/game/hud, as that correctly uses the private registry, even if yarn doesn't.

I also had to set "forceConsistentCasingInFileNames": false in my tsconfig.json to squash TS1149 errors with import statements from hud/..., due to the directory on disk being named HUD.

I've not included either in the PR because it might be somehow specific to my setup here.

@sysrage

sysrage commented Nov 6, 2019

Copy link
Copy Markdown

Since yarn was ignoring the private registry in .npmrc, we tried adding the following to .yarnrc:

"@csegames:registry" "http://registry.camelotunchained.com"

This doesn't seem to work.

@sysrage

sysrage commented Nov 7, 2019

Copy link
Copy Markdown

While working with Salty, we found that everything breaks again if Node is upgraded to 12.x. The above workarounds only work with Node 10.x.

@krugar

krugar commented Nov 7, 2019

Copy link
Copy Markdown
Author

Right, I should have stated that I tried this with LTS/Dubnium (v10.17.0 at time of writing), given that the project requires v7.4.X, which I would read as LTS/Carbon (v8.16.2 atm)?

edit: btw, CircleCI failed because hatcheryapi was down broken at the time:

@csegames/camelot-unchained: nps is executing definitions : download https://hatcheryapi.camelotunchained.com/codegen/definitions.ts > ./src/webAPI/definitions.ts
@csegames/camelot-unchained: HTTPError: Response code 500 (Internal Server Error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants