[CUBRIDQA-1461] keep the diff_ignore_lineno() temporary files - #777
Merged
Conversation
The previous commit made diff_ignore_lineno() delete the two *_temp_diff files it creates. That broke shell/_38_fig/cbrd_24478/deduplicate, whose case CUBRID#7 asserts on one of them: compare_result_between_files create_table_data.log create_table_data.answer if [ -f create_table_data.answer_temp_diff ];then write_ok "[create table checked]" else write_nok "[create table fail]" fi Once the function removed the file the condition was never true, so the case wrote NOK and the test case failed. Drop the removal and let diff be the last command again, so its exit code stays the return value of the function without the 'rc' plumbing. The temporary files are the test case's to clean up: of the 43 references to '*_temp_diff' in the shell test cases, the one above reads the file and the remaining 42 delete it at the end of the script, 13 of them with a bare 'rm' that also fails once the glob matches nothing. The Korean and English masking added in the previous commit is unchanged, as are 'cp -f' and the quoted file names. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Reviews (1): Last reviewed commit: "[CUBRIDQA-1461] keep the diff_ignore_lin..." | Re-trigger Greptile |
kwonhoil
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
#776에서
diff_ignore_lineno()가 생성하는*_temp_diff임시파일 2개를 함수 안에서 삭제하도록 바꿨는데, 이 때문에shell/_38_fig/cbrd_24478/deduplicate테스트케이스가 실패했습니다.이 테스트의 case #7은 임시파일의 존재 자체를 검증 조건으로 사용합니다 (
deduplicate.sh:66):함수가 파일을 지우면 조건이 절대 참이 되지 않아
write_nok가 실행되고,.result에 NOK가 남아 테스트케이스가 실패합니다.변경 내용
rm -f를 제거하고diff를 다시 함수의 마지막 명령으로 되돌립니다. 그러면diff의 종료 코드가 자연히 함수의 반환값이 되므로rc처리도 함께 제거됩니다.임시파일 정리는 테스트케이스의 책임입니다. shell 테스트케이스의
*_temp_diff참조 43건을 확인한 결과:deduplicate.sh:66)-f없는 barerm *_temp_diff**로, 라이브러리가 파일을 먼저 지우면 glob이 매칭되지 않아 이rm도 실패합니다 (테스트 실패로는 이어지지 않지만 로그에 에러가 남습니다)#776에서 추가한 영문·한글 마스킹,
cp -f, 파일명 인용은 그대로 유지됩니다.검증
원인 재현 — case #7의 조건을 동일하게 구성해 두 버전을 비교:
develop(rm -f있음)NOK [create table fail]rm -f제거)OK [create table checked]회귀 확인
rm *_temp_diff가 다시exit=0으로 성공bash -n통과참고
grep으로*_temp_diff참조를 조사할 때deduplicate.sh:66이 누락되어 초기에 "모든 참조가 삭제 용도"라고 잘못 판단했습니다.find | xargs grep으로 다시 확인해 읽기 참조 1건을 찾았고, 그것이 정확한 실패 원인이었습니다.🤖 Generated with Claude Code