[APIS-1088] Remove protocol compatibility - #83
Merged
Conversation
http://jira.cubrid.org/browse/APIS-1088 - Removes compatibility for protocol version prior to V9.
|
Reviews (1): Last reviewed commit: "- Update version to 11.4" | Re-trigger Greptile |
|
Reviews (2): Last reviewed commit: "- apply code format" | Re-trigger Greptile |
Srltas
reviewed
Jul 29, 2026
Srltas
left a comment
Member
There was a problem hiding this comment.
더 이상 참조하는 곳이 없는 코드는 정리하는 것이 어떤가요?
| 대상 | 위치 |
|---|---|
| PROTOCOL_V0 ~ PROTOCOL_V8 | UConnection.java:91-99 |
| protoVersionIsSame() | UConnection.java:1883 |
| UFunctionCode.CURSOR_CLOSE_FOR_PROTOCOL_V2 | UFunctionCode.java:93 |
| BrokerHandler.cancelBroker() | BrokerHandler.java:289 |
public API를 바로 제거하는 것이 부담이 된다면 @Deprecated를 추가하는 것도 좋을 것 같습니다.
Comment on lines
428
to
434
| @@ -435,25 +435,17 @@ private void connectDB(int timeout) throws IOException, UJciException { | |||
Member
There was a problem hiding this comment.
구 방식 프로토콜을 구분하는 부분으로 이제 더 이상 유지할 필요가 없을 것 같습니다.
버전을 계산 후 거부하는 것보다 해당 비트를 검사 후 구 버전이면 바로 거부하는 것으로 수정하는 것이 어떤가요?
해당 로직을 제거하면서 makeBrokerVersion(), BROKER_INFO_MAJOR_VERSION, BROKER_INFO_MINOR_VERSION, BROKER_INFO_PATCH_VERSION도 더 이상 사용하는 곳이 없어 정리하는 것도 좋아보입니다.
Collaborator
Author
There was a problem hiding this comment.
| 대상 | 검토 |
|---|---|
| PROTOCOL_V0 ~ PROTOCOL_V8 | 유지 |
| protoVersionIsSame() | protoVersionIsAbove를 제외하고 삭제 |
| CURSOR_CLOSE_FOR_PROTOCOL_V2 | 유지 |
| BrokerHandler.cancelBroker() | cancelBrokerEx->cancelBroker로 변경 |
| 구 버전 관련사항 | 삭제 |
| CTP 테스트를 고려하여 위와 같이 정리하였습니다. |
Collaborator
Author
|
@greptile 리뷰 부탁해 |
|
Reviews (3): Last reviewed commit: "- removed about old broker version" | Re-trigger Greptile |
Srltas
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/APIS-1088
Purpose
V9 미만의 호환성 코드 제거
Implementation
Remark
N/A