Skip to content

Security vulnerability in docker compose #38

Description

@aaraney

@Castronova, it looks like 73328c5 and 57f7baa introduced security vulnerabilities with the inclusion of oauth configuration data. We probably should prune these commits from the tree (this will be a pain) or at the least, they should be removed and new oauth configuration secrets be generated.

In the future, we should use a docker .env file that is never added to this repo that contains this and any other sensitive data. See the compose docs for examples. Likewise, I see that the ssl certs are being accessed from a volume mount, we probably should move these to docker-compose secrets that are treated with more care and are always read only. See the compose docs on this subject for an example (I also included one below).

version: "3.9"
services:
  redis:
    image: redis:latest
    environment: 
      SSL_CERT: /run/secrets/ssl_cert
    secrets:
      - ssl_cert
secrets:
  ssl_cert:
    file: "${SSL_CERT}"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions