removed date sorting logic causing problems with plots - #215
Open
Castronova wants to merge 1 commit into
Open
Conversation
…hin the time_str variable. This was causing the datetimes to become misaligned with the data, creating incorrect plots
✅ Deploy Preview for swotviz ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Zahraa222
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were sorting the date_str variable returned by Hydrocron, but since this may contain no_data values it was causing a problem. Datetimes were becoming misaligned with the other data (e.g. wse) and this was resulting in incorrect plots.