Skip to content

Hotfix/FCT2-22256 use south region vol uuids - #611

Merged
lilachdavis merged 5 commits into
mainfrom
hotfix/use-south-region-vol-uuids
Oct 6, 2026
Merged

lilachdavis merged 5 commits into
mainfrom
hotfix/use-south-region-vol-uuids

Conversation

@lilachdavis

@lilachdavis lilachdavis commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

The security group <-> bucket mapping points to bucket UUIDs that are only correct when targeting the West instance of the netapp CVO.
The equivalent buckets in the South region all have different UUIDs.
Use the NetAppOptions__RegionName variable to dynamically use the correct mapping for the active region.

PR checklist

Correctness

  • Does what the ticket asks for
  • Handles the edge cases (empty, null, zero, large inputs), not just the happy path
  • Errors are handled, not swallowed
  • New logic has tests, including the failure cases
  • Tests assert something real, not just run the code

Keeping it simple

  • Doesn't rebuild something that already exists in the codebase
  • No more complex or slower than it needs to be
  • No leftover debug logging or commented-out code

Code Quality

  • Pre-commit hooks were run for all commits in this PR

Easy to miss (a green pipeline won't flag these)

  • One logical change, not a pile of unrelated stuff

@lilachdavis lilachdavis changed the title Hotfix/use south region vol uuids Hotfix/FCT2-22256 use south region vol uuids Oct 5, 2026
Comment thread backend/CPS.ComplexCases.API/Services/SercurityGroupMetadataService.cs Outdated
Comment thread backend/CPS.ComplexCases.API/Services/SercurityGroupMetadataService.cs Outdated
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

@HasanCPS HasanCPS left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lilachdavis
lilachdavis merged commit 4d45c45 into main Oct 6, 2026
13 checks passed
@lilachdavis
lilachdavis deleted the hotfix/use-south-region-vol-uuids branch October 6, 2026 14:23
HasanCPS added a commit that referenced this pull request Oct 8, 2026
* subtask/FCT2-22142 Add separate test flow for PRs from development -> main (#597)

* Hotfix/FCT2-22256 use south region vol uuids (#611)

---------

Co-authored-by: Lilach <Lilach.Davis@cps.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants