Skip to content

FCT2-21135- removed the featuregroup2 restriction for disconnectSharedDrive and transferMaterialV1 features - #531

Merged
bridgesr merged 1 commit into
mainfrom
story/FCT2-21135-Remove-FeatureGroup2-Restrictions
Aug 4, 2026
Merged

FCT2-21135- removed the featuregroup2 restriction for disconnectSharedDrive and transferMaterialV1 features#531
bridgesr merged 1 commit into
mainfrom
story/FCT2-21135-Remove-FeatureGroup2-Restrictions

Conversation

@renjithabby

@renjithabby renjithabby commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Tick what applies before you raise. Delete anything that doesn't.

Correctness

  • Does what the ticket asks for
  • Handles the edge cases (empty, null, zero, large inputs), not just the happy path
  • Errors are handled, not swallowed
  • New logic has tests, including the failure cases
  • Tests assert something real, not just run the code

Keeping it simple

  • Doesn't rebuild something that already exists in the codebase
  • No more complex or slower than it needs to be
  • No leftover debug logging or commented-out code

Easy to miss (a green pipeline won't flag these)

  • One logical change, not a pile of unrelated stuff

If you touched the UI

  • API changes are reflected in the MSW handlers in src/mocks and the matching zod schema, so the mocked tests aren't passing against a contract that's gone
  • New config or feature flags are wired into the VITE build variables, not just added in code
  • Data fetches handle the loading, empty and error states, not just success, and match how the rest of the app already does it
  • Ran prettier (npm run prettier:format), since CI lints but doesn't check formatting
  • Checked accessibility (keyboard nav, screen reader, sensible labels), since the Lighthouse run is manual and won't flag it for you

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@bridgesr
bridgesr merged commit 7792ece into main Aug 4, 2026
11 checks passed
@bridgesr
bridgesr deleted the story/FCT2-21135-Remove-FeatureGroup2-Restrictions branch August 4, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants