Skip to content

fix: increase polling grace period to prevent false transfer errors (FCT2-20905) #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HasanCPS merged 2 commits into from
Jul 31, 2026
Merged

fix: increase polling grace period to prevent false transfer errors (FCT2-20905) #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f175829
FCT2-20905: cap adaptive polling interval at configurable maximum
HasanCPS Jul 30, 2026
09c3726
FCT2-20905: fix test
HasanCPS Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui-spa/src/common/utils/pollTransferStatus.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,9 @@ describe("pollTransferStatus", async () => {
100,
);

// The grace window is 30s of wall-clock. Just before it elapses the loop is
// The grace window is 90s of wall-clock. Just before it elapses the loop is
// still polling and has not surfaced an error.
await vi.advanceTimersByTimeAsync(29900);
await vi.advanceTimersByTimeAsync(89900);
expect(handleResponse).to.toHaveBeenCalledTimes(0);
expect(handleError).to.toHaveBeenCalledTimes(0);
expect(getTransferStatus).to.toHaveBeenCalled();
Expand All @@ -270,7 +270,7 @@ describe("pollTransferStatus", async () => {

// The loop has given up: no further polling and no further errors.
const callsAfterStop = (getTransferStatus as Mock).mock.calls.length;
await vi.advanceTimersByTimeAsync(30000);
await vi.advanceTimersByTimeAsync(90000);
expect(getTransferStatus).to.toHaveBeenCalledTimes(callsAfterStop);
expect(handleError).to.toHaveBeenCalledTimes(1);
});
Expand Down
2 changes: 1 addition & 1 deletion ui-spa/src/common/utils/pollTransferStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const MID_INTERVAL_MS = 3000;
* instead of polling forever (e.g. an orchestration that failed before the
* entity was created, or a stale/incorrect transfer ID).
*/
const NOT_FOUND_GRACE_MS = 30000;
const NOT_FOUND_GRACE_MS = 90000; // 90s

/**
* Polls the transfer status endpoint with adaptive backoff until a terminal state is reached
Expand Down
Loading