Skip to content

Task/fct2 20588 add validation enhancements to e2 e playwright tests - #515

Open
kmshrajcps wants to merge 18 commits into
mainfrom
task/FCT2-20588_Add-validation-enhancements-to-E2E-playwright-tests
Open

Task/fct2 20588 add validation enhancements to e2 e playwright tests#515
kmshrajcps wants to merge 18 commits into
mainfrom
task/FCT2-20588_Add-validation-enhancements-to-E2E-playwright-tests

Conversation

@kmshrajcps

Copy link
Copy Markdown
Contributor

PR checklist

Correctness

  • Does what the ticket asks for
  • Handles the edge cases (empty, null, zero, large inputs), not just the happy path
  • Errors are handled, not swallowed
  • New logic has tests, including the failure cases
  • Tests assert something real, not just run the code

Keeping it simple

  • Doesn't rebuild something that already exists in the codebase
  • No more complex or slower than it needs to be
  • No leftover debug logging or commented-out code

Easy to miss (a green pipeline won't flag these)

  • One logical change, not a pile of unrelated stuff

If you touched the UI

  • Ran the e2e/ suite locally (the PR build only runs the mocked tests; the full suite runs post-merge and gates
    the deploy)

lilachdavis and others added 18 commits July 16, 2026 14:54
…nsfer flow

The deployed Shared Drive transfer screen replaced the "Move selected" button
and destination-tree page with an inline destination-inset control
("<action> to <folder>") and a "Transfer confirmation alert modal" whose
Continue button is gated on an acknowledgement checkbox.

- clickTransferControl: click the inset button (netapp-inset-text /
  egress-inset-text) by its "<action> to " accessible-name prefix
- confirmTransfer: tick the "I want to <copy|move> N file(s) to <folder>"
  checkbox, then Continue; drop the destination-tree flow
- remove the now-unused TransferDestinationPage import and refresh the class
  doc comment
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants