Remove old deprecated code#1050
Conversation
IgnaceBleukx
left a comment
IgnaceBleukx
left a comment
There was a problem hiding this comment.
Nice cleanup, I would keep the deprecated args to the transformation functions for a next release, we haven't had a release yet where the user was warned about them with a proper error message?
| :func:`cpmpy.transformations.reification.reify_rewrite` | ||
| E.g. ``bv -> NumExpr <comp> Var/Const`` will then be rewritten as ``[bv -> IV0 <comp> Var/Const, NumExpr == IV0]``. | ||
| """ | ||
| assert _toplevel is None, "decompose_in_tree: argument '_toplevel' is deprecated, do not use/modify it" |
There was a problem hiding this comment.
For this one I'm not sure, we have not had a release yet where it is deprecated, so maybe wait one more?
There was a problem hiding this comment.
I added the arguments back, but with a warning instead of an assert (since the latter would be an equal sudden breaking change to removing the argument)
|
|
||
|
|
||
| def no_partial_functions(lst_of_expr: list[Expression], | ||
| _toplevel: Optional[Any]=None, |
There was a problem hiding this comment.
Same here, we haven't had a release yet where this had a warning
|
Are many of the examples not broken now? I should resume my clean up of those.. |
|
I can confirm all examples run, so should be good to merge? (also very nicely documented in the changelog btw : ) ) |
3 participants
Removing old code that has been deprecated for a while. Some are still left in place due to
Partially solves #1048. The removed code will be documented in the changelog of v1.0.0 and in the docs #1038