fix tests and test docs#1002
Merged
Merged
Conversation
OrestisLomis
approved these changes
Jun 18, 2026
OrestisLomis
left a comment
OrestisLomis
left a comment
Contributor
There was a problem hiding this comment.
Made some small changes, because it seemed to me like a test was misplaced + I added in the native mus cleanup here. Good to merge for me :)
Contributor
|
aah wait forgot that not all solvers can do MUS with assumptions.. |
Contributor
|
Okay, so to be clear I changed some more things but all is still scoped to this PR. It now works fine, but I had to set Exact as the solver for the standard MUS tests because #961 does not work (and also isn't in master yet). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using
requires_solver()in tests ALSO requires listing a 'solver' parameter in the function definition, otherwise the test is always run